x86 build updated .targets file and Weaver.Directory.build.targets#221
Open
Victor80jhub wants to merge 21 commits into
Open
x86 build updated .targets file and Weaver.Directory.build.targets#221Victor80jhub wants to merge 21 commits into
Victor80jhub wants to merge 21 commits into
Conversation
MrAdviceStitcher.cs: Added string.SubString for assembly location which was sometimes reported wrong. MrAdvice.targets: Replaced dotnet with executable and added $(platform) to the path Overall: Added build configurations for x86 and x64
x86 Build Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Directory.build.targets so that AnyCPU builds also trigger an x86 build for the specified workload while building Weaver itself.
Updated Weaver.targets so that only x86 builds on Windows uses .exe file
Tested scenarios:
Windows build solution in VS: AnyCPU, x86, x64
Windows build project in VS: AnyCPU, x86, x64
Windows build solution in terminal using CLI: AnyCPU, x86, x64
Windows build project in terminal using CLI: AnyCPU, x86, x64
Ubuntu build solution in VSCode
Ubuntu build project in VSCode
Ubuntu build solution in terminal using CLI
Ubuntu build project in terminal using CLI