Skip to content

JTO-3: add Claude Code repository guidance#538

Open
dliang123 wants to merge 1 commit into
AsyncFuncAI:mainfrom
dliang123:agent/agent/74c8f170
Open

JTO-3: add Claude Code repository guidance#538
dliang123 wants to merge 1 commit into
AsyncFuncAI:mainfrom
dliang123:agent/agent/74c8f170

Conversation

@dliang123

Copy link
Copy Markdown

No description provided.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: multica-agent <github@multica.ai>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new CLAUDE.md file providing comprehensive guidance, development commands, and architecture details for Claude Code. The review feedback correctly identifies that backend execution and test commands need to be run within the Poetry virtual environment (using poetry run -C api) to prevent module resolution errors.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread CLAUDE.md
Comment on lines +22 to +23
# Start the FastAPI server on PORT or 8001
python -m api.main

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since backend dependencies are installed using Poetry in the api directory (poetry install -C api), running python -m api.main directly from the repository root will fail with ModuleNotFoundError because the virtual environment is not active. To run the backend server correctly using the Poetry environment, prefix the command with poetry run -C api.

Suggested change
# Start the FastAPI server on PORT or 8001
python -m api.main
# Start the FastAPI server on PORT or 8001
poetry run -C api python -m api.main

Comment thread CLAUDE.md
Comment on lines +53 to +67
# All tests via the project runner
python tests/run_tests.py

# Test categories
python tests/run_tests.py --unit
python tests/run_tests.py --integration
python tests/run_tests.py --api

# Single test file examples
python tests/unit/test_google_embedder.py
python tests/api/test_api.py

# Pytest directly, when useful
pytest tests/unit/test_google_embedder.py
pytest tests/unit/test_google_embedder.py::test_name

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to starting the backend, running the tests directly with python or pytest from the repository root will fail to locate the installed dependencies (like adalflow, requests, etc.) unless executed within the Poetry virtual environment. Prefix these commands with poetry run -C api to ensure they run in the correct environment.

Suggested change
# All tests via the project runner
python tests/run_tests.py
# Test categories
python tests/run_tests.py --unit
python tests/run_tests.py --integration
python tests/run_tests.py --api
# Single test file examples
python tests/unit/test_google_embedder.py
python tests/api/test_api.py
# Pytest directly, when useful
pytest tests/unit/test_google_embedder.py
pytest tests/unit/test_google_embedder.py::test_name
# All tests via the project runner
poetry run -C api python tests/run_tests.py
# Test categories
poetry run -C api python tests/run_tests.py --unit
poetry run -C api python tests/run_tests.py --integration
poetry run -C api python tests/run_tests.py --api
# Single test file examples
poetry run -C api python tests/unit/test_google_embedder.py
poetry run -C api python tests/api/test_api.py
# Pytest directly, when useful
poetry run -C api pytest tests/unit/test_google_embedder.py
poetry run -C api pytest tests/unit/test_google_embedder.py::test_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant