-
Notifications
You must be signed in to change notification settings - Fork 876
[Alternate] Podcast Episode block: post-bound (single source of truth) #48546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robertbpugh
wants to merge
14
commits into
trunk
Choose a base branch
from
add/podcast-episode-block-postbound
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,495
−2
Open
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4b323a6
Add Podcast Episode block
arcangelini 5ae6aa0
Podcast Episode: split ternary __() calls so i18n extractor can read …
arcangelini 3f1fb0f
Podcast Episode: post-bound alternate (one source of truth for title/…
robertbpugh a5c2286
Podcast Episode: use block context, reuse convertSecondsToTimeCode, r…
robertbpugh e4cafed
Podcast Episode: read post via block context, defer mejs lookup, tigh…
robertbpugh e692d14
Podcast Episode: episode cover art override, drop excerpt/GUID UI
robertbpugh b43bc73
Podcast Episode: fix CI lint/phpcs/phan/build errors
robertbpugh 266c716
Potential fix for pull request finding
robertbpugh a0313a6
Potential fix for pull request finding
robertbpugh e175206
Potential fix for pull request finding
robertbpugh 246b6cf
Address PR review comments: coverArt guard, TRANSCRIPT_TYPE_OPTIONS i…
Copilot e10ceac
Podcast Episode: use get_block_wrapper_attributes for class+style output
robertbpugh 43094b3
Podcast Episode: drop get_block_wrapper_attributes, fix PHPCS alignment
robertbpugh 381cc4c
Podcast Episode: use null coalescing for $original_post (Phan)
robertbpugh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: enhancement | ||
|
|
||
| Podcast Episode block: new block to embed a single podcast episode from an audio or video file with Podcasting 2.0 metadata. | ||
107 changes: 107 additions & 0 deletions
107
projects/plugins/jetpack/extensions/blocks/podcast-episode/block.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| { | ||
| "$schema": "https://schemas.wp.org/trunk/block.json", | ||
| "apiVersion": 3, | ||
| "name": "jetpack/podcast-episode", | ||
| "title": "Podcast Episode", | ||
| "description": "Embed a single podcast episode from an audio or video file, with Podcasting 2.0 metadata.", | ||
| "keywords": [ "audio", "podcast", "episode" ], | ||
| "version": "1.0.0", | ||
| "textdomain": "jetpack", | ||
| "category": "embed", | ||
| "icon": "<svg viewBox='0 0 24 24' width='24' height='24' xmlns='http://www.w3.org/2000/svg'><path d='M12 2a5 5 0 0 0-5 5v5a5 5 0 0 0 10 0V7a5 5 0 0 0-5-5zm0 2a3 3 0 0 1 3 3v5a3 3 0 0 1-6 0V7a3 3 0 0 1 3-3zm-7 8a1 1 0 0 1 1 1 6 6 0 0 0 12 0 1 1 0 1 1 2 0 8 8 0 0 1-7 7.93V22h3v2H8v-2h3v-1.07A8 8 0 0 1 4 13a1 1 0 0 1 1-1z'/></svg>", | ||
| "usesContext": [ "postId", "postType", "queryId" ], | ||
| "supports": { | ||
| "spacing": { | ||
| "padding": true, | ||
| "margin": true | ||
| }, | ||
| "anchor": true, | ||
| "customClassName": true, | ||
| "className": true, | ||
| "html": false, | ||
| "multiple": true, | ||
| "reusable": true | ||
| }, | ||
| "attributes": { | ||
| "mediaId": { | ||
| "type": "integer" | ||
| }, | ||
| "mediaUrl": { | ||
| "type": "string" | ||
| }, | ||
| "mediaType": { | ||
| "type": "string", | ||
| "enum": [ "audio", "video" ] | ||
| }, | ||
| "mediaMimeType": { | ||
| "type": "string" | ||
| }, | ||
| "mediaSize": { | ||
| "type": "integer" | ||
| }, | ||
| "episodeNumber": { | ||
| "type": "integer" | ||
| }, | ||
| "seasonNumber": { | ||
| "type": "integer" | ||
| }, | ||
| "episodeType": { | ||
| "type": "string", | ||
| "enum": [ "full", "trailer", "bonus" ], | ||
| "default": "full" | ||
| }, | ||
| "explicit": { | ||
| "type": "boolean", | ||
| "default": false | ||
| }, | ||
| "duration": { | ||
| "type": "string", | ||
| "default": "" | ||
| }, | ||
| "transcriptUrl": { | ||
| "type": "string", | ||
| "default": "" | ||
| }, | ||
| "transcriptType": { | ||
| "type": "string", | ||
| "enum": [ "text/vtt", "text/html", "application/srt", "application/json" ], | ||
| "default": "text/vtt" | ||
| }, | ||
| "chaptersUrl": { | ||
| "type": "string", | ||
| "default": "" | ||
| }, | ||
| "locationName": { | ||
| "type": "string", | ||
| "default": "" | ||
| }, | ||
| "license": { | ||
| "type": "string", | ||
| "default": "" | ||
| }, | ||
| "licenseUrl": { | ||
| "type": "string", | ||
| "default": "" | ||
| }, | ||
| "people": { | ||
| "type": "array", | ||
| "default": [] | ||
| }, | ||
| "showPoster": { | ||
| "type": "boolean", | ||
| "default": true | ||
| }, | ||
| "coverArt": { | ||
| "type": "object", | ||
| "default": {} | ||
| } | ||
| }, | ||
| "example": { | ||
| "attributes": { | ||
| "episodeNumber": 1, | ||
| "seasonNumber": 1, | ||
| "episodeType": "full", | ||
| "duration": "11:25" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.