Skip to content

Modules: auto activate offline-compatible modules even if not connect-ready #48554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simison wants to merge 2 commits into
base: trunk
Choose a base branch
from
+11 −6
Open

Modules: auto activate offline-compatible modules even if not connect-ready #48554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41d2785
Modules: auto activate offline modules even if not connect-ready
simison May 6, 2026
11b2879
changelog
simison May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/enable-offline-default-modules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Modules: Auto-activate default modules that do not require a connection on unconnected sites, including Forms.
13 changes: 7 additions & 6 deletions projects/plugins/jetpack/class.jetpack.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2754,9 +2754,7 @@ public static function plugin_initialize() {
Jetpack_Options::update_options( compact( 'version', 'old_version' ) );
}

if ( self::is_connection_ready() ) {
self::handle_default_module_activation( true );
}
self::handle_default_module_activation( true );

self::load_modules();

Expand All @@ -2773,7 +2771,8 @@ public static function plugin_initialize() {
* require a user connection activated.
*/
private static function handle_default_module_activation( $should_activate_user_modules ) {
$active_modules = Jetpack_Options::get_option( 'active_modules' );
$connection_ready = self::is_connection_ready();
$active_modules = Jetpack_Options::get_option( 'active_modules' );
if ( $active_modules ) {
self::delete_active_modules();

Expand All @@ -2797,11 +2796,13 @@ private static function handle_default_module_activation( $should_activate_user_
$active_modules,
false
);
} elseif ( $should_activate_user_modules && ( new Connection_Manager() )->get_connection_owner_id() ) { // Check for a user connection.
} elseif ( $connection_ready && $should_activate_user_modules && ( new Connection_Manager() )->get_connection_owner_id() ) { // Check for a user connection.
self::activate_default_modules( false, false, array(), false, null, null, null );
Jetpack_Options::update_option( 'active_modules_initialized', true );
} else {
} elseif ( $connection_ready ) {
self::activate_default_modules( false, false, array(), false, null, null, false );
} else {
self::activate_default_modules( false, false, array(), false, null, false, false );
}
}

Expand Down
Loading