Jetpack Sitemaps: wrap post column names in backticks to handle SQL reserved words

[matticbot]

Problem

When a site has a custom column on wp_posts whose name matches a SQL reserved word (e.g. order), the sitemap generation query fails with a SQL syntax error. This was reported as a conflict with the Solid Backups Legacy plugin causing backups to fail.

Root Cause

Jetpack_Sitemap_Librarian::get_sanitized_post_columns() fetches all columns from wp_posts and interpolates them into a SELECT statement without quoting:

return implode( ',', array_map( 'esc_sql', $columns ) );

If any column name is a SQL reserved keyword, the query becomes syntactically invalid.

Fix

Wrap each column name in backtick quotes so MySQL/MariaDB treats them as identifiers regardless of whether they are reserved words:

return '`' . implode( '`,`', array_map( 'esc_sql', $columns ) ) . '`';

Testing

1. Add a column named order (or another SQL reserved word) to wp_posts.
2. Visit a sitemap URL (e.g. /sitemap.xml).
3. Before fix: SQL error is thrown and the sitemap fails to generate.
4. After fix: sitemap generates correctly.

References

• Linear: TSTAISB-56

---

Linear: TSTAISB-56

This PR was auto-generated by AI Coder. Please review carefully before merging.

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the ai/agent/tstaisb-56-1778075081 branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack ai/agent/tstaisb-56-1778075081

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  
• 🔴 Add testing instructions.
  
• 🔴 Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

## Testing instructions:

* Go to '..'
*

---

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

## Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report