Blaze: extract campaign preparer (ADS-1036)#48570
Blaze: extract campaign preparer (ADS-1036)#48570j6ll wants to merge 2 commits intoadd/ads-953-blaze-create-campaign-abilityfrom
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
|
Quick ADS-1036 test/status pass — 2026-05-06 Local focused Blaze tests pass: Status notes:
Next action: wait for the remaining CI logs/rerun signal before marking ADS-1036 complete. ADS-1044 is now the right follow-up for the broader audience targeting options contract. |
Fixes ADS-1036
Proposed changes
Campaign_Preparer.Blaze_Abilitiesfocused on registration, permissions, guardrails, and MCP-specific message formatting.Related product discussion/links
Does this pull request change what data or activity we track or use?
No. This refactors existing prepare-campaign behavior behind the same public response and does not add tracking.
Testing instructions
projects/packages/blaze, runcomposer run phpunit -- --filter Campaign_Preparer_Test.projects/packages/blaze, runcomposer run phpunit -- --filter Blaze_Abilities_Test.projects/packages/blaze, runcomposer run phpunit -- --filter 'Campaign_Preparer_Test|Blaze_Abilities_Test'.php -l projects/packages/blaze/src/class-campaign-preparer.php && php -l projects/packages/blaze/src/abilities/class-blaze-abilities.php && php -l projects/packages/blaze/tests/php/Campaign_Preparer_Test.php.Note: I also ran the full Blaze package PHPUnit suite locally; the preparer and ability tests passed, but the full suite hit the existing
Dashboard_Test::test_load_admin_scriptsstyle assertion because ignored localprojects/packages/blaze/dist/build.min.*files make the dashboard load local assets instead of CDN assets in this checkout.