Skip to content

Write: fix publish status message for existing drafts#48577

Merged
kbrown9 merged 1 commit intotrunkfrom
update/write_publish_button
May 7, 2026
Merged

Write: fix publish status message for existing drafts#48577
kbrown9 merged 1 commit intotrunkfrom
update/write_publish_button

Conversation

@kbrown9
Copy link
Copy Markdown
Member

@kbrown9 kbrown9 commented May 6, 2026

Fixes RSM-2439

Proposed changes

  • Fix isUpdate flag in savePost() to check the current post status (state.postStatus) instead of the target status (postStatus parameter).
  • This corrects the status message when publishing an existing draft — it now shows "Publishing…" / "Published!" instead of "Updating…" / "Updated!".

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  1. Create a new post and save it as a draft (or use an existing draft post).
  2. Open the draft in the Write editor: wp-admin/admin.php?page=write&post={id}
  3. Click the Publish button.
  4. Before fix: Status message flashes "Updating…" then "Updated!".
  5. After fix: Status message flashes "Publishing…" then "Published!".
  6. Also verify that updating an already published post still shows "Updating…" / "Updated!".

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

The isUpdate flag in savePost() checked the target status (postStatus
parameter) instead of the current post status (state.postStatus), so
publishing an existing draft showed "Updating…" / "Updated!" instead
of "Publishing…" / "Published!".

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@kbrown9 kbrown9 added the [Status] Needs Review This PR is ready for review. label May 6, 2026
@kbrown9 kbrown9 self-assigned this May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the update/write_publish_button branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/write_publish_button

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report

@kbrown9 kbrown9 merged commit 81db1f4 into trunk May 7, 2026
70 checks passed
@kbrown9 kbrown9 deleted the update/write_publish_button branch May 7, 2026 18:31
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant