Podcast: simplify wp-build wiring per #48557 review#48600
Podcast: simplify wp-build wiring per #48557 review#48600arcangelini wants to merge 8 commits intotrunkfrom
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Follow-up to #48557 and #48559 addressing review feedback from @simison.
Proposed changes
Admin_Page(projects/packages/podcast/src/class-admin-page.php) down to the same wp-build wiring shape asJetpack_Backup(Backup: add empty wp-build dashboard scaffold behind feature flag #48583): polyfills register + wp-build entry require +current_screenalias of$screen->idtojetpack-podcast-dashboard.bridge_wp_build_enqueue()(the$_GET[page]swap) andfix_boot_import_map_ordering()(the boot-script reorder workaround). wp-build's auto-generated enqueue callback handles enqueue once$screen->idmatches; the import-map fix isn't needed in this path.wpcom_reorder_submenu()from two entries (jetpack-podcast,podcasting) to a singlepodcast.wpcom_reorder_submenudoes substring matching, and only one of the two URLs is ever registered at a time, so one entry covers both flag states.StageinsidePagefrom@wordpress/admin-ui(matching the Newsletter pattern in Newsletter: port Subscribers DataViews onto the modernization chassis #48581) — title/subtitle in the page header, tabs in the body. Replaces the bare<h1>Podcast</h1> + <Tabs.Root>layout.Related product discussion/links
n/a
Does this pull request change what data or activity we track or use?
No.
Testing instructions
pnpm jetpack build packages/podcast --deps.wp-config.php:wp-admin/admin.php?page=jetpack-podcast. The page should render inside the@wordpress/admin-uiPage chrome — "Podcast" title, the tagline as subtitle, and the four placeholder tabs (Settings / Episodes / Distribution / Stats) below. DevTools → Network should request frombuild/pages/jetpack-podcast-dashboard/. No console errors.projects/packages/podcast/build/and reload), the page still renders the bare<h1>Podcast</h1>placeholder via the PHP fallbackAdmin_Page::render().