Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Podcast: write Activity Log entries on podcast publish #48693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podcast: write Activity Log entries on podcast publish #48693
Changes from 6 commits
108f5cf8e591c546840661c3c2967db79585eefb7b8857a9c62a2aeaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
automattic/jetpack-syncas a podcast package dep transitively pulls inautomattic/jetpack-connection(Sync requires it), so\Automattic\Jetpack\Trackingresolves for Phan from this package now. Restoring the@phan-suppress-next-line PhanUndeclaredClassMethodwould itself be flagged as an unused suppression. Leaving it removed is correct in the new dep state.Check warning on line 41 in projects/packages/podcast/tests/php/Tracks_Test.php
Check warning on line 42 in projects/packages/podcast/tests/php/Tracks_Test.php
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.