Skip to content

[network] Fix --ttl option missing from az network private-dns record-set * add-record commands #33277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

[network] Fix --ttl option missing from az network private-dns record-set * add-record commands #33277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c795954
Initial plan
Copilot Apr 28, 2026
9ad6fd3
Fix --ttl option for private-dns record-set add-record commands
Copilot Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/azure-cli/azure/cli/command_modules/privatedns/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,15 @@ def load_arguments(self, _):
for item in ['a', 'aaaa', 'cname', 'mx', 'ptr', 'srv', 'txt']:
with self.argument_context('network private-dns record-set {} add-record'.format(item)) as c:
c.argument('relative_record_set_name', options_list=('--record-set-name', '-n'), help='The name of the record set relative to the zone. Creates a new record set if one does not exist.')
c.argument('ttl', type=int, help='Record set TTL (time-to-live)')

with self.argument_context('network private-dns record-set {} remove-record'.format(item)) as c:
c.argument('relative_record_set_name', options_list=('--record-set-name', '-n'), help='The name of the record set relative to the zone.')
c.argument('keep_empty_record_set', action='store_true', help='Keep the empty record set if the last record is removed.')

with self.argument_context('network private-dns record-set cname set-record') as c:
c.argument('relative_record_set_name', options_list=['--record-set-name', '-n'], help='The name of the record set relative to the zone. Creates a new record set if one does not exist.')
c.argument('ttl', type=int, help='Record set TTL (time-to-live)')

with self.argument_context('network private-dns record-set soa') as c:
c.argument('relative_record_set_name', ignore_type, default='@')
Expand Down
33 changes: 18 additions & 15 deletions src/azure-cli/azure/cli/command_modules/privatedns/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ def _privatedns_add_record(record_set, record, record_type, is_list=False):
record_set[record_property] = record


def _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, is_list=True):
def _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, is_list=True, ttl=None):
record_snake, record_camel = _privatedns_type_to_property_name(record_type)
is_empty = False

Expand All @@ -948,6 +948,9 @@ def _privatedns_add_save_record(cmd, record, record_type, relative_record_set_na
record_set = {"ttl": 3600}
is_empty = True

if ttl is not None:
record_set["ttl"] = ttl

_privatedns_add_record(record_set, record, record_type, is_list)

if is_empty:
Expand All @@ -970,37 +973,37 @@ def _privatedns_add_save_record(cmd, record, record_type, relative_record_set_na
})


def add_privatedns_aaaa_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, ipv6_address):
def add_privatedns_aaaa_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, ipv6_address, ttl=None):
record = {"ipv6_address": ipv6_address}
record_type = 'aaaa'
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name)
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, ttl=ttl)


def add_privatedns_a_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, ipv4_address):
def add_privatedns_a_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, ipv4_address, ttl=None):
record = {"ipv4_address": ipv4_address}
record_type = 'a'
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name)
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, ttl=ttl)


def add_privatedns_mx_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, preference, exchange):
def add_privatedns_mx_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, preference, exchange, ttl=None):
record = {"preference": int(preference), "exchange": exchange}
record_type = 'mx'
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name)
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, ttl=ttl)


def add_privatedns_ptr_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, dname):
def add_privatedns_ptr_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, dname, ttl=None):
record = {"ptrdname": dname}
record_type = 'ptr'
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name)
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, ttl=ttl)


def add_privatedns_srv_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, priority, weight, port, target):
def add_privatedns_srv_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, priority, weight, port, target, ttl=None):
record = {"priority": priority, "weight": weight, "port": port, "target": target}
record_type = 'srv'
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name)
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, ttl=ttl)


def add_privatedns_txt_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, value):
def add_privatedns_txt_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, value, ttl=None):
record = {"value": value}
record_type = 'txt'
long_text = ''.join(x for x in record["value"])
Expand All @@ -1013,13 +1016,13 @@ def add_privatedns_txt_record(cmd, resource_group_name, private_zone_name, relat
final_str = ''.join(record["value"])
final_len = len(final_str)
assert original_len == final_len
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name)
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, ttl=ttl)


def add_privatedns_cname_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, cname):
def add_privatedns_cname_record(cmd, resource_group_name, private_zone_name, relative_record_set_name, cname, ttl=None):
record = {"cname": cname}
record_type = 'cname'
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, is_list=False)
return _privatedns_add_save_record(cmd, record, record_type, relative_record_set_name, resource_group_name, private_zone_name, is_list=False, ttl=ttl)


def update_privatedns_soa_record(cmd, resource_group_name, private_zone_name, host=None, email=None,
Expand Down
Loading
Loading