Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a security concern by preventing potential EUII leakage in the x-ms-app header when running in Node (e.g., avoiding sending full filesystem paths that may include usernames).
Changes:
- Update Node default application name resolution to use only the basename of
process.argv[1]instead of the full path. - Add a
pathimport to support basename extraction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
|
||
| import { isNodeLike } from "@azure/core-util"; | ||
| import { userInfo } from "os"; | ||
| import { basename } from "path"; |
Comment on lines
+40
to
+42
| // Use only the base filename from argv[1] to avoid leaking the full | ||
| // filesystem path (which may contain the username). | ||
| return process?.env?.npm_package_name || (process?.argv?.[1] ? basename(process.argv[1]) : None); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security
Prevent leaking EUII from the file's path (e.g. "C:\Users\jdoe...\kusto-mcp-server\dist\index.js")