Skip to content

Sync eng/common directory with azure-sdk-tools for PR 15500#49083

Merged
scbedd merged 2 commits intomainfrom
sync-eng/common-allow-https-binding-15500
May 7, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 15500#49083
scbedd merged 2 commits intomainfrom
sync-eng/common-allow-https-binding-15500

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#15500 See eng/common workflow

Copilot AI review requested due to automatic review settings May 7, 2026 00:27
@azure-sdk azure-sdk requested a review from a team as a code owner May 7, 2026 00:27
@azure-sdk azure-sdk requested a review from scbedd May 7, 2026 00:27
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR syncs eng/common test proxy pipeline templates with the corresponding updates from azure-sdk-tools PR 15500, adding support for configuring the test-proxy bind URL and using it consistently when starting and probing the proxy.

Changes:

  • Add a proxyUrl parameter (defaulting to http://localhost:5000) to the test-proxy pipeline templates.
  • Pass the configured URL into test-proxy startup via -- --urls ... (Windows + Linux/mac).
  • Use proxyUrl when calling the proxy Admin/IsAlive endpoint.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
eng/common/testproxy/test-proxy-tool.yml Adds proxyUrl parameter; starts test-proxy with --urls and probes IsAlive using the configured URL.
eng/common/testproxy/test-proxy-standalone-tool.yml Same as above for the standalone tool variant, including updated nohup invocation.

Comment thread eng/common/testproxy/test-proxy-tool.yml
Comment thread eng/common/testproxy/test-proxy-standalone-tool.yml
@scbedd scbedd merged commit 5a967f4 into main May 7, 2026
19 checks passed
@scbedd scbedd deleted the sync-eng/common-allow-https-binding-15500 branch May 7, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants