Skip to content

[Mgmt] Profile Network generator performance #59541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
live1206 wants to merge 2 commits into from
Closed

[Mgmt] Profile Network generator performance #59541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1f9079
Add management generator profiling instrumentation
live1206 May 29, 2026
b1621e6
Handle non-model LRO final results in management generator
live1206 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 27 additions & 18 deletions ...-client-csharp-mgmt/generator/Azure.Generator.Management/src/ManagementClientGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,34 +53,43 @@ public override TypeProviderWriter GetWriter(TypeProvider provider)
// Model factory back-compat overloads can be synthesized from LastContractView
// after normal visitors run. Repair them here so the final methods being written
// preserve arguments that were moved into flattened model properties.
ModelFactoryBackwardCompatHelper.FixModelFactoryBackwardCompatOverloads(modelFactory.Methods);
using (ProfilingTimer.Measure("FixModelFactoryBackwardCompatOverloads", $"{modelFactory.Name}; methods={modelFactory.Methods.Count}"))
{
ModelFactoryBackwardCompatHelper.FixModelFactoryBackwardCompatOverloads(modelFactory.Methods);
}
}

return base.GetWriter(provider);
using (ProfilingTimer.Measure("GetWriter", provider.Name))
{
return base.GetWriter(provider);
}
}

/// <summary>
/// Customize the generation output for Azure client SDK.
/// </summary>
protected override void Configure()
{
base.Configure();
// Include Azure.ResourceManager
AddMetadataReference(MetadataReference.CreateFromFile(typeof(ArmClient).Assembly.Location));
// renaming should come first
AddVisitor(new NameVisitor());
AddVisitor(new SerializationVisitor());
AddVisitor(new RestClientVisitor());
AddVisitor(new ResourceVisitor());
AddVisitor(new InheritableSystemObjectModelVisitor());
AddVisitor(new FlattenPropertyVisitor());
AddVisitor(new TypeFilterVisitor());
AddVisitor(new PaginationVisitor());
AddVisitor(new ModelFactoryVisitor());
AddVisitor(new ManagedIdentityV3Visitor());
if (IsWirePathEnabled())
using (ProfilingTimer.Measure(nameof(Configure)))
{
AddVisitor(new WirePathVisitor());
base.Configure();
// Include Azure.ResourceManager
AddMetadataReference(MetadataReference.CreateFromFile(typeof(ArmClient).Assembly.Location));
// renaming should come first
AddVisitor(new NameVisitor());
AddVisitor(new SerializationVisitor());
AddVisitor(new RestClientVisitor());
AddVisitor(new ResourceVisitor());
AddVisitor(new InheritableSystemObjectModelVisitor());
AddVisitor(new FlattenPropertyVisitor());
AddVisitor(new TypeFilterVisitor());
AddVisitor(new PaginationVisitor());
AddVisitor(new ModelFactoryVisitor());
AddVisitor(new ManagedIdentityV3Visitor());
if (IsWirePathEnabled())
{
AddVisitor(new WirePathVisitor());
}
}
}

Expand Down
Loading