Skip to content

[specs] add missing ARM scenarios#4632

Merged
iscai-msft merged 16 commits into
Azure:mainfrom
iscai-msft:specs/addArmTests
Jul 17, 2026
Merged

[specs] add missing ARM scenarios#4632
iscai-msft merged 16 commits into
Azure:mainfrom
iscai-msft:specs/addArmTests

Conversation

@iscai-msft

@iscai-msft iscai-msft commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #4609

  1. getLro with @markAsLro
  2. postActionPaging
  3. @markAsPageable
  4. postPaginglroWithBody
  5. legacy template usages

@microsoft-github-policy-service microsoft-github-policy-service Bot added the lib:azure-http-specs For issues/prs related to the @azure-tools/typespec-azure-http-specs package label Jun 15, 2026
@azure-sdk

azure-sdk commented Jun 15, 2026 •
edited by azure-sdk-automation Bot
Loading

Copy link
Copy Markdown
Collaborator

All changed packages have been documented.

  • ✅ @azure-tools/azure-http-specs
  • ✅ @azure-tools/typespec-python
  • ✅ @azure-tools/typespec-ts
Show changes

@azure-tools/typespec-python - internal ✏️

Suppress too-many-statements pylint check for the generated azure-resource-manager-operation-templates package

@azure-tools/typespec-ts - internal ✏️

Regenerate the operation-templates public-API baseline for the new ARM operations

@azure-tools/azure-http-specs - feature ✏️

Add tests for ARM getLro, postActionPaging, markAsPageable, postPagingLroWithBody, routedGet, and createOrReplaceOptionalBody

@github-actions

github-actions Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚡ Benchmark Results

✅ No performance regressions detected.

Full details – comparing 3c35619 vs baseline rolling-baseline-f6e42f0-aca5355 (rolling baseline (20 main runs))
Metric Baseline Current Change
total 🔴 1.00s 🔴 1.03s +2.1%
loader 🟡 303.9ms 🟡 309.9ms +2.0%
resolver 🟢 39.9ms 🟢 39.2ms -1.6%
checker 🟡 362.3ms 🟡 371.2ms +2.5%
validation 🟢 84.5ms 🟢 85.4ms +1.2%
 ↳ validation/@azure-tools/typespec-azure-core 🟡 12.5ms 🟡 13.0ms +3.4%
 ↳ validation/@typespec/http 🟡 15.4ms 🟡 15.8ms +2.7%
 ↳ validation/@typespec/rest 🟢 1.6ms 🟢 1.6ms +1.2%
 ↳ validation/@typespec/versioning 🔴 50.9ms 🔴 51.1ms +0.3%
 ↳ validation/compiler 🟢 3.8ms 🟢 3.8ms +0.2%
linter 🟡 213.8ms 🟡 219.9ms +2.8%
 ↳ linter/@azure-tools/typespec-azure-core/auth-required 🟢 0.1ms 🟢 0.1ms +5.2%
 ↳ linter/@azure-tools/typespec-azure-core/bad-record-type 🟢 0.6ms 🟢 0.6ms -0.8%
 ↳ linter/@azure-tools/typespec-azure-core/byos 🟢 8.3ms 🟢 8.4ms +1.6%
 ↳ linter/@azure-tools/typespec-azure-core/casing-style 🟢 1.4ms 🟢 1.4ms -0.2%
 ↳ linter/@azure-tools/typespec-azure-core/composition-over-inheritance 🟢 0.2ms 🟢 0.2ms +3.2%
 ↳ linter/@azure-tools/typespec-azure-core/documentation-required 🟢 1.9ms 🟢 2.0ms +0.7%
 ↳ linter/@azure-tools/typespec-azure-core/friendly-name 🟢 1.4ms 🟢 1.4ms +0.8%
 ↳ linter/@azure-tools/typespec-azure-core/key-visibility-required 🟢 0.4ms 🟢 0.4ms +3.1%
 ↳ linter/@azure-tools/typespec-azure-core/known-encoding 🟢 0.5ms 🟢 0.5ms +2.3%
 ↳ linter/@azure-tools/typespec-azure-core/long-running-polling-operation-required 🟢 0.8ms 🟢 0.8ms -0.8%
 ↳ linter/@azure-tools/typespec-azure-core/no-case-mismatch 🟢 0.7ms 🟢 0.7ms -1.0%
 ↳ linter/@azure-tools/typespec-azure-core/no-closed-literal-union 🟢 1.0ms 🟢 1.0ms -1.3%
 ↳ linter/@azure-tools/typespec-azure-core/no-enum 🟢 0.2ms 🟢 0.2ms +1.2%
 ↳ linter/@azure-tools/typespec-azure-core/no-error-status-codes 🟢 0.3ms 🟢 0.3ms +1.4%
 ↳ linter/@azure-tools/typespec-azure-core/no-explicit-routes-resource-ops 🟢 0.2ms 🟢 0.2ms +0.5%
 ↳ linter/@azure-tools/typespec-azure-core/no-format 🟢 0.8ms 🟢 0.8ms +0.3%
 ↳ linter/@azure-tools/typespec-azure-core/no-generic-numeric 🟢 0.8ms 🟢 0.8ms +0.2%
 ↳ linter/@azure-tools/typespec-azure-core/no-header-explode 🔴 26.5ms 🔴 27.8ms +4.8%
 ↳ linter/@azure-tools/typespec-azure-core/no-legacy-usage 🟢 2.0ms 🟢 2.1ms +2.2%
 ↳ linter/@azure-tools/typespec-azure-core/no-multiple-discriminator 🟢 0.2ms 🟢 0.2ms +5.1%
 ↳ linter/@azure-tools/typespec-azure-core/no-nullable 🟢 0.4ms 🟢 0.4ms +3.2%
 ↳ linter/@azure-tools/typespec-azure-core/no-offsetdatetime 🟢 1.9ms 🟢 2.0ms +2.7%
 ↳ linter/@azure-tools/typespec-azure-core/no-openapi 🟢 2.3ms 🟢 2.3ms -0.9%
 ↳ linter/@azure-tools/typespec-azure-core/no-private-usage 🟢 3.1ms 🟢 3.2ms +0.6%
 ↳ linter/@azure-tools/typespec-azure-core/no-query-explode 🔴 27.7ms 🔴 29.0ms +5.0%
 ↳ linter/@azure-tools/typespec-azure-core/no-response-body 🔴 33.0ms 🔴 34.2ms +3.4%
 ↳ linter/@azure-tools/typespec-azure-core/no-rest-library-interfaces 🟢 0.1ms 🟢 0.1ms -1.7%
 ↳ linter/@azure-tools/typespec-azure-core/no-route-parameter-name-mismatch 🟢 7.6ms 🟢 7.9ms +3.6%
 ↳ linter/@azure-tools/typespec-azure-core/no-rpc-path-params 🟢 0.4ms 🟢 0.4ms +3.2%
 ↳ linter/@azure-tools/typespec-azure-core/no-string-discriminator 🟢 0.1ms 🟢 0.1ms +3.5%
 ↳ linter/@azure-tools/typespec-azure-core/no-unknown 🟢 0.3ms 🟢 0.4ms +3.9%
 ↳ linter/@azure-tools/typespec-azure-core/no-unnamed-union 🟢 0.8ms 🟢 0.8ms -0.1%
 ↳ linter/@azure-tools/typespec-azure-core/operation-missing-api-version 🟢 0.4ms 🟢 0.4ms -2.8%
 ↳ linter/@azure-tools/typespec-azure-core/request-body-problem 🟢 0.5ms 🟢 0.5ms +0.0%
 ↳ linter/@azure-tools/typespec-azure-core/require-versioned 🟢 0.1ms 🟢 0.1ms +2.3%
 ↳ linter/@azure-tools/typespec-azure-core/response-schema-problem 🔴 32.5ms 🔴 33.2ms +2.1%
 ↳ linter/@azure-tools/typespec-azure-core/rpc-operation-request-body 🟢 0.7ms 🟢 0.7ms +4.0%
 ↳ linter/@azure-tools/typespec-azure-core/spread-discriminated-model 🟢 0.5ms 🟢 0.5ms -0.3%
 ↳ linter/@azure-tools/typespec-azure-core/use-standard-names 🟢 7.5ms 🟢 7.8ms +3.3%
 ↳ linter/@azure-tools/typespec-azure-core/use-standard-operations 🟢 0.3ms 🟢 0.3ms -0.8%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-child-resources 🔴 21.4ms 🔴 22.4ms +4.4%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-agent-base-type-lifecycle-operations 🟢 0.3ms 🟢 0.3ms +5.8%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-common-types-version 🟡 12.1ms 🟡 12.6ms +3.9%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-no-key 🟢 0.2ms 🟢 0.2ms +4.4%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-custom-resource-usage-discourage 🟢 0.1ms 🟢 0.1ms +3.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes 🟢 4.9ms 🟢 4.6ms -5.8%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-path-casing-conflicts 🟡 17.0ms 🟡 17.4ms +2.2%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-no-record 🟢 0.6ms 🟢 0.6ms +1.8%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-post-operation-response-codes 🟢 1.4ms 🟢 1.4ms +1.9%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes 🟢 0.2ms 🟢 0.2ms -6.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-action-no-segment 🟢 0.4ms 🟢 0.4ms -0.7%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-duplicate-property 🟢 0.4ms 🟢 0.4ms +4.4%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-interface-requires-decorator 🟢 0.1ms 🟢 0.1ms +9.2%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-action-verb 🟢 0.2ms 🟢 0.2ms -2.4%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-envelope-property 🟢 0.3ms 🟢 0.3ms +3.4%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-invalid-version-format 🟢 0.2ms 🟢 0.2ms -0.6%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-key-invalid-chars 🟢 0.5ms 🟢 0.5ms +6.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-name-pattern 🟢 0.1ms 🟢 0.1ms +8.9%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation 🟢 0.5ms 🟢 0.5ms -3.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-operation-response 🟢 8.9ms 🟢 9.1ms +2.3%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-patch 🟢 0.8ms 🟢 0.8ms -1.7%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-path-segment-invalid-chars 🟢 0.4ms 🟢 0.4ms +2.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/arm-resource-provisioning-state 🟢 0.4ms 🟢 0.4ms +1.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/beyond-nesting-levels 🟢 0.2ms 🟢 0.2ms +4.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/empty-updateable-properties 🟢 0.4ms 🟢 0.5ms +13.8%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/improper-subscription-list-operation 🟢 0.1ms 🟢 0.1ms +10.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/lro-location-header 🟡 19.5ms 🔴 20.1ms +3.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-operations-endpoint 🟢 0.1ms 🟢 0.1ms +1.9%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/missing-x-ms-identifiers 🟢 1.0ms 🟢 1.0ms -1.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-empty-model 🟢 0.3ms 🟢 0.3ms +3.0%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-override-props 🟢 0.3ms 🟢 0.3ms +1.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-resource-delete-operation 🟢 0.5ms 🟢 0.5ms +3.6%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/no-response-body 🔴 29.7ms 🔴 30.6ms +3.1%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/patch-envelope 🟢 0.4ms 🟢 0.4ms +2.2%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/resource-name 🟢 0.4ms 🟢 0.4ms +1.9%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/secret-prop 🟢 5.4ms 🟢 5.3ms -1.8%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/unsupported-type 🟢 0.7ms 🟢 0.7ms +0.5%
 ↳ linter/@azure-tools/typespec-azure-resource-manager/version-progression 🟢 0.3ms 🟢 0.3ms +0.3%
 ↳ linter/@azure-tools/typespec-client-generator-core/property-name-conflict 🟢 2.3ms 🟢 2.3ms +1.3%
 ↳ linter/@azure-tools/typespec-client-generator-core/require-client-suffix 🟢 1.7ms 🟢 1.7ms +0.2%
emit 🔴 6.01s 🔴 6.15s +2.3%
 ↳ emit/@Azure-Tools 🟢 0.0ms 🟢 0.0ms +0.0%
 ↳ emit/@azure-tools/typespec-autorest 🟢 124.4ms 🟢 126.2ms +1.4%
 ↳ emit/@azure-tools/typespec-python 🔴 2.24s 🔴 2.30s +2.6%
 ↳ emit/@typespec 🟢 0.0ms 🟢 0.0ms +0.0%
 ↳ emit/@typespec/http-client-js 🔴 566.7ms 🔴 574.8ms +1.4%
 ↳ emit/@typespec/openapi3 🟢 106.9ms 🟢 108.8ms +1.7%
 ↳ emit/@typespec/openapi3/compute 🟢 92.9ms 🟢 94.4ms +1.6%
 ↳ emit/@typespec/openapi3/write 🟢 13.8ms 🟢 14.0ms +2.0%

Averaged across 3 specs (azure-arm-resource-manager, azure-core-dataplane, azure-full).
Threshold: changes > ±5% are highlighted.
🟢 Fast · 🟡 Moderate (stages >200ms, rules >10ms) · 🔴 Slow (stages >400ms, rules >20ms)

@pkg-pr-new

pkg-pr-new Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/azure-http-specs@4632

npm i https://pkg.pr.new/@azure-tools/typespec-python@4632

npm i https://pkg.pr.new/@azure-tools/typespec-ts@4632

commit: b8a4695

@azure-sdk

azure-sdk commented Jun 15, 2026 •
edited by azure-sdk-automation Bot
Loading

Copy link
Copy Markdown
Collaborator

You can try these changes here

🛝 Playground 🌐 Website

XiaofeiCao
XiaofeiCao reviewed Jun 16, 2026
View reviewed changes
Comment thread .chronus/changes/specs-addArmTests-2026-5-15-14-14-34.md Outdated
XiaofeiCao
XiaofeiCao reviewed Jun 16, 2026
View reviewed changes
Comment thread packages/azure-http-specs/specs/azure/resource-manager/operation-templates/mockapi.ts Outdated
XiaofeiCao
XiaofeiCao reviewed Jun 22, 2026
View reviewed changes
Comment thread packages/azure-http-specs/specs/azure/resource-manager/operation-templates/mockapi.ts Outdated
@iscai-msft
iscai-msft enabled auto-merge June 23, 2026 15:16
@iscai-msft
iscai-msft added this pull request to the merge queue Jul 6, 2026
@microsoft-github-policy-service microsoft-github-policy-service Bot added the stale Mark a PR that hasn't been recently updated and will be closed. label Jul 8, 2026
@iscai-msft
iscai-msft added this pull request to the merge queue Jul 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 10, 2026
iscai-msft and others added 2 commits July 15, 2026 11:21
Merge branch 'main' of https://github.com/Azure/typespec-azure into s…
2c7181f 
…pecs/addArmTests
[python] suppress too-many-statements pylint for operation-templates …
84ff372 
…generated package

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a62aea37-5ec4-46a4-a79b-58b3c908270a
@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:python Issues for @azure-tools/typespec-python emitter label Jul 15, 2026
@iscai-msft
iscai-msft added this pull request to the merge queue Jul 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 15, 2026
[ts] regenerate operation-templates index.d.ts baseline for new ARM o…
511bf69 
…perations

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a62aea37-5ec4-46a4-a79b-58b3c908270a
@microsoft-github-policy-service microsoft-github-policy-service Bot added the emitter:typescript Issues for @azure-tools/typespec-ts emitter label Jul 15, 2026
iscai-msft and others added 3 commits July 15, 2026 19:43
Merge remote-tracking branch 'upstream/main' into specs/addArmTests
9cbe5a3
[ts] add changeset for regenerated operation-templates baseline
df29b51 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a62aea37-5ec4-46a4-a79b-58b3c908270a
[python] add armIdWithGroupScope to common-properties mock API tests
b8a4695 
The common-properties spec added the armIdWithGroupScope property (Azure#4891),
but the hand-written mock API tests were not updated, so the request body
no longer matched the mock server's expected body.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a62aea37-5ec4-46a4-a79b-58b3c908270a
@iscai-msft
iscai-msft added this pull request to the merge queue Jul 17, 2026
Merged via the queue into Azure:main with commit ebc22fc Jul 17, 2026
35 checks passed
@iscai-msft
iscai-msft deleted the specs/addArmTests branch July 17, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes
@XiaofeiCao XiaofeiCao XiaofeiCao approved these changes
@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner
@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner
@joheredi joheredi Awaiting requested review from joheredi
@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner
@weidongxu-microsoft weidongxu-microsoft Awaiting requested review from weidongxu-microsoft weidongxu-microsoft is a code owner
@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh is a code owner
@jhendrixMSFT jhendrixMSFT Awaiting requested review from jhendrixMSFT jhendrixMSFT is a code owner
@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner
@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner
@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner
@l0lawrence l0lawrence Awaiting requested review from l0lawrence l0lawrence is a code owner
@ChenxiJiang333 ChenxiJiang333 Awaiting requested review from ChenxiJiang333 ChenxiJiang333 is a code owner
@kashifkhan kashifkhan Awaiting requested review from kashifkhan kashifkhan is a code owner
@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner
@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner
@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner
@JialinHuang803 JialinHuang803 Awaiting requested review from JialinHuang803 JialinHuang803 is a code owner
@xirzec xirzec Awaiting requested review from xirzec xirzec is a code owner

Assignees

No one assigned

Labels

emitter:python Issues for @azure-tools/typespec-python emitter emitter:typescript Issues for @azure-tools/typespec-ts emitter lib:azure-http-specs For issues/prs related to the @azure-tools/typespec-azure-http-specs package stale Mark a PR that hasn't been recently updated and will be closed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[specs] Push to add more coverage for ARM scenarios

4 participants

@iscai-msft @azure-sdk @timotheeguerin @XiaofeiCao