Skip to content

[pre-commit.ci] pre-commit autoupdate#1167

Open
pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config
Open

[pre-commit.ci] pre-commit autoupdate#1167
pre-commit-ci[bot] wants to merge 1 commit into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci

@pre-commit-ci pre-commit-ci Bot commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 5481bce to 1d9f59a Compare May 12, 2025 18:56
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 1d9f59a to 2b65538 Compare May 19, 2025 19:00
@adeelsohailahmed adeelsohailahmed requested a review from a team May 23, 2025 00:50
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 2b65538 to b2baba0 Compare May 26, 2025 18:58
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from c5822a3 to 4eca05b Compare June 9, 2025 18:58
@staticxterm

Copy link
Copy Markdown
Member

Due to update of mypy, some checks are now failing. In my testing, mypy fails on a lot of files in Beanie codebase, as it's simply not "up to its standards".
I plan to work on fixing these typing issues soon.
So I would hold off on merging this low-hanging fruit regarding uplift of dependencies/pre-commit hooks until then.

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 4eca05b to 8ee6504 Compare June 16, 2025 18:41
@staticxterm

Copy link
Copy Markdown
Member

@adeelsohailahmed, regarding this PR and the failing pre-commit check,

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

beanie/odm/utils/find.py:385: error: Incompatible types in assignment (expression has type "Any | None", variable has type "dict[str, Any]")  [assignment]

I have opened #1191 which should among other things also fix this failure:

root_text_query_args: Union[dict[str, Any], None] = query.get("$text")

It would be great if we could have that huge PR merged, could you please take a look when you have the time?

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 8cfd4d6 to 28db7d3 Compare June 30, 2025 18:54
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 28db7d3 to 5e435df Compare July 7, 2025 19:28
Riverfount
Riverfount previously approved these changes Jul 8, 2025

@Riverfount Riverfount left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I made a mistake here!

@staticxterm

Copy link
Copy Markdown
Member

Really @Riverfount? We have CI tests failing, and if we check for this locally, it would also fail locally when trying to commit...

@Riverfount Riverfount self-requested a review July 9, 2025 16:55
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 5e435df to 48ff0ed Compare July 14, 2025 19:03
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from de300c3 to 2bed2b4 Compare July 28, 2025 19:10
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 2bed2b4 to c60e1f6 Compare August 4, 2025 19:36
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from c60e1f6 to 310d9ae Compare August 11, 2025 19:45
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 057cdcf to eb9d88d Compare January 26, 2026 19:42
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from eb9d88d to 8f22a20 Compare February 9, 2026 20:46
roman-right
roman-right previously approved these changes Feb 16, 2026

@roman-right roman-right left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roman-right

Copy link
Copy Markdown
Member

Note: CI is currently failing here, but that is caused by the outdated mongodb-action version, which #1277 fixes. The pre-commit changes themselves are fine. This will need a rebase after #1277 is merged to get green CI.

@roman-right roman-right dismissed their stale review February 16, 2026 05:23

Duplicate.

@roman-right

Copy link
Copy Markdown
Member

@Riverfount Sorry, I accidentally dismissed your reviews while testing an automation tool. Could you please re-review when you get a chance? Apologies for the inconvenience.

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 8f22a20 to 7f3ad88 Compare February 16, 2026 19:31
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 7f3ad88 to 0f3a7b4 Compare February 23, 2026 19:49
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 9ac1bc9 to 096305b Compare March 9, 2026 20:00
Riverfount
Riverfount previously approved these changes Mar 9, 2026

@Riverfount Riverfount left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 942f368 to e1a69f4 Compare March 23, 2026 19:38
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from e1a69f4 to 17d8854 Compare March 30, 2026 19:35
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 16087f7 to 833b842 Compare April 13, 2026 19:39
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 833b842 to b49842f Compare April 20, 2026 19:29
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from b49842f to eaa01c4 Compare April 27, 2026 20:00
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from eaa01c4 to 37980b4 Compare May 11, 2026 19:31
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from d1a83aa to 49481c9 Compare May 25, 2026 19:50
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 1e76f77 to 8ebe6b5 Compare June 8, 2026 19:42
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 8ebe6b5 to 4ac8549 Compare June 15, 2026 19:48
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch 2 times, most recently from 2a66e0a to 6f2644a Compare June 29, 2026 19:43
updates:
- https://github.com/charliermarsh/ruff-pre-commithttps://github.com/astral-sh/ruff-pre-commit
- [github.com/astral-sh/ruff-pre-commit: v0.14.14 → v0.15.21](astral-sh/ruff-pre-commit@v0.14.14...v0.15.21)
- [github.com/pre-commit/mirrors-mypy: v1.19.1 → v2.3.0](pre-commit/mirrors-mypy@v1.19.1...v2.3.0)
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 6f2644a to 445fa90 Compare July 13, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants