fix: use experiment-wide min/max for eFP colour scale instead of group#174
Merged
fix: use experiment-wide min/max for eFP colour scale instead of group#174
Conversation
Collaborator
|
LGTM as well |
Collaborator
Author
|
Thanks; just a simple fix:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is directly on top of staging to fix the colouring issue where instead of pulling the experimental max, it was pulling the group-max for each tissue, often making things very red. Instead we want a global max. This also fixed the heat scale issue (sometimes doubling up and making weird glitches).
Technical:
Just fixed what is being passed and and sorted.
Before:
After:
