Conversation
* Add tests for autoload. Fails until Autoload fix is merged. * explicitly assert all candidate names are the same * remove duplicate functions
* Support ES&S CVRs with multiple contests * Fix implementation and two erroneous tests * info -> auditable * Print number of ignored rows * single config option to handle blanks * Read Write-In images * Simplify: remove options for skipped rank text and blank=write-in * lint * re-introduce leniency with blank labels * fix portland results * fix "blank as UWI" test --> now uses images * fix portland mayor codes test: replace CVR images with "undervote" * add missing CVRs to git * clean-up * remove deprecated rows * handle migration to remove UWI label for ES&S * replace blank cells with "undervote"; fix maxNumRankings * migrations should occur every load, including in tests * reimplement UWI label for ES&S; don't use magic TEST version * remove skipped rank label from ES&S * fix regex * PR review comments: no default UWI; handle unlimited rankings * PR reviews: clean up; all images must be handled * bugfix: handle rows with all-empty cells * only read images in relevant cells * PR comments * simplify changes to first_round_determines_threshold_test * PR Review * PR Review
artoonie
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.1.0 release candidate. This PR specifically includes
Not included in this PR since it was already merged to master from dev as a v2.0.2 release that was never built (because we decided to include the above PRs) is #978 - allow RCTab user to explicitly allocate more heap size. Since we merged it to master but never made the planned v2.0.2 release, v2.1.0 will be the first official release with #978