ci: pass VITE_FRINGE_SHEET_NAME to the code-quality workflow#229
Open
rileychh wants to merge 1 commit into
Open
ci: pass VITE_FRINGE_SHEET_NAME to the code-quality workflow#229rileychh wants to merge 1 commit into
rileychh wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pan93412
approved these changes
May 5, 2026
mirumodapon
approved these changes
May 9, 2026
The Fringe loader reads `env.VITE_FRINGE_SHEET_NAME`, but only deploy-to-pages.yaml exports it. In code-quality.yaml the variable was undefined, so the loader's URL became `…/values/undefined?key=…`, Sheets returned 400 INVALID_ARGUMENT, and the loader logged `Error fetching fringes: No data found in the spreadsheet` on every PR build. Mirror the deploy workflow's env block so PR builds see the same secret.
rileychh
force-pushed
the
fix-fringe-ci-env
branch
from
b24bdfc to
7b6e3a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loaders/fringe.data.tsreadsenv.VITE_FRINGE_SHEET_NAME, but onlydeploy-to-pages.yamlexports it —code-quality.yamldoesn't. On PR builds the URL becomes…/values/undefined?key=…, Sheets returns 400, and every CI log carriesError fetching fringes: No data found in the spreadsheet. Non-fatal (loader catches and returns `[]`), but it leaves PR previews with an empty Fringe section.The repo secret already exists (created 2025-08-02); this one line wires it through.
Test plan