refactor: replace staff API loader with static data#231
Open
rileychh wants to merge 1 commit into
Open
Conversation
The volunteer.coscup.org host has been shut down, so the loader's call to volunteer.coscup.org/api/members fails CI's pnpm build with HTML-where-JSON errors. Capture the rendered staff list from coscup.org/2025/staff (12 groups, 164 members) into data/staff.json and import it from the loader. Drop the chiefs dedup, the ' - ' name split, and the unused data/conference import — group.zh_tw / group.en are pre-baked into the JSON, and tid is synthesized as a sequential string (only used as Vue :key, never displayed). StaffGroup narrows to the fields the templates actually read (tid, group, members), so StaffZh.vue / StaffEn.vue need no change. Out of scope: the participate/*.md files still reference dead volunteer.coscup.org image and doc URLs, and the staff welcome section's "register as volunteer" CTA is left as-is. Recovery is impossible without human input (no Wayback snapshots, no alt host, no bundled copies anywhere).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pan93412
approved these changes
May 5, 2026
mirumodapon
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
volunteer.coscup.orghas been shut down (every URL on that host returns 404), so the staff loader's runtime fetch tohttps://volunteer.coscup.org/api/members?pid=...returns an HTML error page andpnpm buildblows up parsing it as JSON. Captures the rendered staff list from coscup.org/2025/staff and coscup.org/2025/en/staff into a newdata/staff.jsonand rewritesloaders/staff.data.tsto import it.chiefsdedup and' - 'group-name split (both are pre-baked into the JSON), and narrowsStaffGroupto the fields the templates actually consume (tid,group.{zh_tw,en},members[]).Out of scope
The participate
.mdfiles still reference deadvolunteer.coscup.orgimage and doc URLs (6 broken images, 6 dead doc/CTA links), and the staff welcome section's "register as volunteer" CTA is left as-is. Recovery isn't possible without human input — Wayback has no snapshots for that host, no alt host carries the assets, and Vite doesn't bundle raw-HTML<img src="https://...">tags in markdown so there are no local copies in dist either. Filing as a follow-up.Test plan
pnpm type-checkclean (loader keeps a compatibleStaffDatashape)jqsanity:{groups: 12, totalMembers: 164, allHaveTids: true, allHaveGroups: true}/staffand/en/staffagainst today's deployed site — group order, member order, and avatars should match