Refactoring Cloudiscovery CLI to support [provider] [resource] format#177
Refactoring Cloudiscovery CLI to support [provider] [resource] format#177jacorbello wants to merge 3 commits intoCloud-Architects:developfrom jacorbello:feature/cli-refactor
Conversation
|
Hi @jacorbello! Thanks for this PR! I'll try to analyze it tomorrow, ok?! 🤟🤟😃😃 |
|
Nice work! 👍🏻 |
leandrodamascena
left a comment
leandrodamascena
left a comment
There was a problem hiding this comment.
Can you fix the version? So, I think it's fine to merge!
Great job!
| sys.exit(1) | ||
|
|
||
| __version__ = "2.4.4" | ||
| __version__ = "2.5.0" |
There was a problem hiding this comment.
As you refactored the arguments and it break actual usage, I think it's make more sense to update to version 3.0.0.
There was a problem hiding this comment.
Makes perfect sense! Just pushed the new version number out.
|
I need to check circleci build, I think it crashed. Checking now. |
Might have been the change in version number, I forgot to update the git tag as well. Just updated that and pushed the tag up. Maybe that'll help? 🤷 |
Hii.. I was full of work last week, but this week I'm focusing in cloudiscovery! Let me fix this PR to merge! |
|
Hey @leandrodamascena, just checking in. Anything I can do to help with this PR? |
3 participants
The purpose of this PR is to refactor the CLI to support multiple cloud providers. The changes proposed here will provide benefits in the following manners:
cloudiscovery aws network --vpc-id vpc-xxxxxxxxcloudiscovery az network --vnet-name my-vnetNote - This is a breaking change for any automated implementations of Cloudiscovery. Commands such as
aws-vpcand similar are no longer supported in this refactor.This is to be the first of a series of pull requests to begin enabling multi-cloud provider support.