Skip to content

fix: exclude paused sections from instrumentation measurement #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
not-matthias wants to merge 4 commits into
base: main
Choose a base branch
from
+27 −3
Open

fix: exclude paused sections from instrumentation measurement #44

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
696eaa1
fix: exclude paused sections from instrumentation measurement
not-matthias Mar 13, 2026
eafc113
fix: exclude paused sections via callgrind collection toggling
not-matthias Jun 5, 2026
198b668
Merge remote-tracking branch 'origin/main' into cod-2033-codspeed-cpp…
not-matthias Jun 5, 2026
4dd226e
ref: exclude benchmark harness from measurement via collection steady…
not-matthias Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion google_benchmark/src/benchmark.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include "codspeed.h"
#include "internal_macros.h"

#ifdef CODSPEED_WALLTIME
#if defined(CODSPEED_WALLTIME) || defined(CODSPEED_ANALYSIS)
#include "measurement.hpp"
#endif

Expand Down Expand Up @@ -272,6 +272,9 @@ void State::PauseTiming() {
#ifdef CODSPEED_WALLTIME
uint64_t pause_timestamp = measurement_current_timestamp();
#endif
#ifdef CODSPEED_ANALYSIS
callgrind_stop_instrumentation();
#endif

// Add in time accumulated so far
BM_CHECK(started_ && !finished_ && !skipped());
Expand Down Expand Up @@ -310,6 +313,9 @@ void State::ResumeTiming() {
BM_CHECK(resume_timestamp_ == 0);
resume_timestamp_ = measurement_current_timestamp();
#endif
#ifdef CODSPEED_ANALYSIS
callgrind_start_instrumentation();
#endif
}

void State::SkipWithMessage(const std::string& msg) {
Expand Down
Loading