Skip to content

fix(valgrind): use %p in log file path to avoid multi-process overwrite #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
not-matthias wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(valgrind): use %p in log file path to avoid multi-process overwrite #381

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62830ac
fix(valgrind): use %p in log file path to avoid multi-process overwrite
not-matthias May 29, 2026
912c389
fix(valgrind): log all per-process valgrind logs on failure
not-matthias May 29, 2026
ce58003
style: cargo fmt
not-matthias May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/executor/valgrind/measure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ pub async fn measure(
}
// Configure valgrind
let valgrind_args = get_valgrind_args(&config.simulation_tool, config);
let log_path = profile_folder.join("valgrind.log");
// Use the %p placeholder so each (potentially forked) process writes to its
// own log file instead of clobbering a shared `valgrind.log` (last writer wins).
let log_path = profile_folder.join("valgrind.%p.log");
cmd.arg("valgrind").args(valgrind_args.iter());
if config.simulation_tool == SimulationTool::Callgrind {
cmd.args(
Expand Down Expand Up @@ -173,10 +175,6 @@ pub async fn measure(

// Check the valgrind exit code
if !status.success() {
let valgrind_log = profile_folder.join("valgrind.log");
let valgrind_log = std::fs::read_to_string(&valgrind_log).unwrap_or_default();
debug!("valgrind.log: {valgrind_log}");

bail!("failed to execute valgrind");
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.

Expand Down