Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 1 | Array-and-Loop#1215
Open
Jacknguyen4438 wants to merge 17 commits into
Open
Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 1 | Array-and-Loop#1215Jacknguyen4438 wants to merge 17 commits into
Jacknguyen4438 wants to merge 17 commits into
Conversation
Jacknguyen4438
added
📅 Sprint 1
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
I will mark this as complete, but please think about the two comments
Comment on lines
+13
to
+15
| // sorted copy for correct median calculation | ||
| const sorted = [...list] | ||
| .filter((items) => typeof items === "number" && !isNaN(items)) |
Member
There was a problem hiding this comment.
filter itself actually returns a copy, so you could skip the [...list] part if you wanted
|
|
||
| if (sorted.length === 0) return null; | ||
|
|
||
| let correctMedian; |
Member
There was a problem hiding this comment.
median feels like a more natural name for this variable than correctMedian - what do you think?
illicitonion
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Hello and thank you for checking this PR. I have done this course before hand and it ready to be review if additional change need to be fix or add please let know thank.
Questions
No Question.