Skip to content

London | 26-ITP-May | Raihan Sharif | Sprint 3 | Quote Generator #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaihanSharif wants to merge 3 commits into
base: main
Choose a base branch
from
Open

London | 26-ITP-May | Raihan Sharif | Sprint 3 | Quote Generator #1221

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f8d1d1
implement quote generator
RaihanSharif Feb 27, 2026
1130932
fix: generate quote on page load, not just on button click.
RaihanSharif May 8, 2026
8897da1
add loadQuote function to generate quotes. Use window load event list…
RaihanSharif May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator</title>
<script defer src="quotes.js"></script>
<link rel="stylesheet" href="style.css" />
</head>
<body>
<h1>hello there</h1>
Expand Down
13 changes: 13 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,3 +491,16 @@ const quotes = [
];

// call pickFromArray with the quotes array to check you get a random quote

const quoteText = document.getElementById("quote");
const authorText = document.getElementById("author");

const newQuoteBtn = document.getElementById("new-quote");

newQuoteBtn.addEventListener("click", () => {
const selectedQuote = pickFromArray(quotes);
quoteText.textContent = selectedQuote.quote;
authorText.textContent = `-- ${selectedQuote.author}`;
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The leading -- appears to be for styling purposes. Keeping it in the CSS or in HTML could allow us to adjust the view without changing any JavaScript code.

});

document.onload = newQuoteBtn.click();
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why assign the return value of .click() to document.onload?

Copy link
Copy Markdown
Author

@RaihanSharif RaihanSharif May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to do window.onload = () => newQuoteBtn.click();

Now uses function to generate quote and calls that instead.

3 changes: 3 additions & 0 deletions Sprint-3/quote-generator/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
/** Write your CSS in here **/
#author {
font-style: italic;
}
Loading