Skip to content

London | 26-ITP-May | Alex Jamshidi | Sprint 3 | Alarm Clock #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alex-Jamshidi wants to merge 6 commits into
base: main
Choose a base branch
from
+47 −2
Open

London | 26-ITP-May | Alex Jamshidi | Sprint 3 | Alarm Clock #1227

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
439144a
added convertTime function
May 13, 2026
2fa60e6
added printTim function
May 13, 2026
0dfe10c
code complete, all tests passed
May 13, 2026
ace2ae8
styled with prettier
May 13, 2026
d14f696
pull request reviewed changes made
May 14, 2026
c69782f
pr review const declaration removed
May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,49 @@
function setAlarm() {}
let timer;

function setAlarm() {
const timeSet = document.getElementById("alarmSet").value;
const time = countdown(timeSet);
Copy link
Copy Markdown
Member

@illicitonion illicitonion May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of this time variable now?

Copy link
Copy Markdown
Author

@Alex-Jamshidi Alex-Jamshidi May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have removed variable assignment as after deleting code snippet before, it is no longer used. countdown(timeSet) is run without result assigned to variable.

}

function countdown(time) {
clearInterval(timer);
let timeRemaining = time;
if (timeRemaining > 5999) {
timeRemaining = 5999;
}
updateShownTime(timeRemaining);

timer = setInterval(() => {
timeRemaining -= 1;
if (timeRemaining == 0) {
clearInterval(timer);
playAlarm();
}
updateShownTime(timeRemaining);
}, 1000);
}

function updateShownTime(timeRemaining) {
let timeRemainingOutput = document.getElementById("timeRemaining");
let title = document.getElementById("title");
const formattedTime = convertTime(timeRemaining);
const printedTime = printTime(formattedTime);
timeRemainingOutput.textContent = `Time Remaining: ${printedTime}`;
title.textContent = `Time Remaining: ${printedTime}`;
}

function convertTime(timeSeconds) {
const seconds = timeSeconds % 60;
const minutes = (timeSeconds - seconds) / 60;
console.log([minutes, seconds]);
return [minutes, seconds];
}

function printTime(time) {
const paddedHours = String(time[0]).padStart(2, "0");
const paddedSeconds = String(time[1]).padStart(2, "0");
return paddedHours + ":" + paddedSeconds;
}

// DO NOT EDIT BELOW HERE

Expand Down
2 changes: 1 addition & 1 deletion Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title id="title">Alarm Clock app</title>
</head>
<body>
<div class="centre">
Expand Down