-
-
Notifications
You must be signed in to change notification settings - Fork 464
London | May-26 | Shahriar Ahmed | Sprint 1 | Form Controls #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SABuilds
wants to merge
22
commits into
CodeYourFuture:main
Choose a base branch
from
SABuilds:Form-Controls
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−26
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2d4ee1f
Added each of the required inputs needed, not right type yet
SABuilds 8212ba3
Moved comments
SABuilds 1bdcd94
My own name added
SABuilds 9ab7553
radio created for colour and for attribute added for each label
SABuilds 55e0651
radio for size but plan to change to select
SABuilds ef2f89a
switched from using radio for size to using select
SABuilds e8ef97d
Added minimum character length to the name input
SABuilds cc5dee9
corrrection to first input element
SABuilds 2f4c453
Added required attribute to size and colour, labelled "select a colou…
SABuilds 3fa36c4
added id to select element
SABuilds 1367253
removed value attribute for label. Added value to the input element
SABuilds 5bfcdb6
removed old comments that are no longer needed
SABuilds 875e3b0
Added a style.css file to improve accessibility for users
SABuilds 5d8d095
add border spacing to id="name"
SABuilds 3d58ced
added id to label and reflected in css
SABuilds b93fb03
reverted changes from previous commit
SABuilds 0c3d909
done the same for css
SABuilds 3f77e46
defined size of #name
SABuilds 362400d
removed width from #name
SABuilds 7c2bfa2
added sizing to #email, #red, #blue, #purple
SABuilds eea81ab
readme file edited
SABuilds 0982e06
read me file actually corrected
SABuilds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| #name { | ||
| height: 24px; | ||
| } | ||
| #email { | ||
| height: 24px; | ||
| } | ||
| #red { | ||
| height: 24px; | ||
| width: 24px; | ||
| } | ||
| #blue { | ||
| height: 24px; | ||
| width: 24px; | ||
| } | ||
| #purple { | ||
| height: 24px; | ||
| width: 24px; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The css is the same for all 3 radio buttons. How could you use less code to achieve the same effect to be applied to all buttons?