check_logfile: imporve file scanning and keep track of lines matched in each file#390
Open
inqrphl wants to merge 3 commits into
Open
check_logfile: imporve file scanning and keep track of lines matched in each file#390inqrphl wants to merge 3 commits into
inqrphl wants to merge 3 commits into
Conversation
…in each file apply conditional filters to the lines early on while adding them, this was not the case before. now the count of lines being passing the filter is correct. add function to generate a detail string from files and the count of matched lines in the file. this can be added to the detailed syntax when needed. if there are no lines matched across all files, change the main output line to say "No matching lines found in files"
inqrphl
force-pushed
the
check-logfile-improve-line-count-tracking-and-output
branch
from
112f913 to
ad5c627
Compare
differentiate between empty states 1) where no files are found, due to given file paths 2) where files are found but do not contain matched lines. write different outputs for both of them, and add tests
inqrphl
force-pushed
the
check-logfile-improve-line-count-tracking-and-output
branch
from
ad5c627 to
e1d777c
Compare
Contributor
|
Should still be UNKNOWN when the file does not exist at all. |
…s exist without matched lines checkdata.finalizeOutput() requires explicit filters or implicit argument filters to apply emptySyntax on output. apply empty syntax on empty state, by setting the "file" and files" argument is set as a filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply conditional filters to the lines early on while adding them, this was not the case before. now the count of lines being passing the filter is correct.
add function to generate a detail string from files and the count of matched lines in the file. this can be added to the detail-syntax when needed. this is saved in check.detail as "file_counts"
Files exist, but do not have matching lines:
No file found: