Check files symlink support#398
Draft
inqrphl wants to merge 6 commits into
Draft
Conversation
added 2 commits
June 30, 2026 10:09
add new argument followSymlinks and new attribute is_symlink add a new file walker, it can resolve file links, and keeps track of visited directories to prevent infinite recursion
Add default value to the followSymlinks argument definition Change is_symlink behavior: it is only toggled on if the file/directory itself is a symlink change the unit of is_symlink to UBool, its filters can now parse bool values
Contributor
|
symbolic links for linux and windows work, but junctions are not recognized yet |
…the resolved paths for tracking visited files/directories. add a new test function for check_files, windows specific for now. uses script to generate symlinks, hardlinks and junctions
… detect hard links and skip over them add bash script to generate filesystem links, and write linux/darwin test for them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default golang filepath.Walk did not traverse into the recursive directories. need to check if a filesystem item is a link using fs.readLink
add a new file walker, it can resolve file links, and keeps track of visited files, directories and inodes
this prevents infinite recursion and adding the same file twice due to hard links
add new argument followSymlinks and new attribute is_symlink.
This attribute is toggled on for symlinks and junctions under windows.
On windows, file walker sees hardlinks like another files, but cannot determine if they are hardlinks or not. So they are added without setting is_symlink on.
On windows, it can detect junctions by checking if FILE_ATTRIBUTE_REPARSE_POINT bit is set in the Win32 file attribute struct. This is on for symlinks and junctions.
On linux, it can detect hardlinks by checking visited inodes array. They are not added on linux.
added a new argument to the check called follow-symlinks, it is true by default.
added a powershell/bash script to dynamically generate some files / links and check related functionality during testing.