Update errorprone, fix javadoc, switch to Maven Central#204
Merged
usmansaleem merged 2 commits intoConsensys:masterfrom Mar 26, 2026
Merged
Update errorprone, fix javadoc, switch to Maven Central#204usmansaleem merged 2 commits intoConsensys:masterfrom
usmansaleem merged 2 commits intoConsensys:masterfrom
Conversation
…eleaser - Update errorprone 2.28.0 -> 2.36.0 and errorprone-checks 1.1.1 -> 1.1.2 - Update errorprone gradle plugin 4.0.1 -> 5.1.0 - Disable new ClassInitializationDeadlock check - Fix javadoc HTML errors (unescaped generics in ExpirationSet, ExpirationScheduler) - Relax javadoc doclint to exclude missing tags (-Xdoclint:all,-missing) - Replace Cloudsmith publishing with JReleaser + Maven Central - Update maven coordinates from tech.pegasys.discovery to io.consensys.protocols - Replace grgit with git-versioning plugin for version calculation - Use java.withJavadocJar()/withSourcesJar() instead of manual sourcesJar task - Update CI workflow: pin actions with SHAs, publish only on tags - Update README with Maven Central badge and new dependency coordinates - Add .factorypath to .gitignore
macfarla
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Xdoclint:all,-missing)io.consensys.protocols:discovery)java.withJavadocJar()/withSourcesJar()Required manual setup
publishenvironment in GitHub repo settingsJRELEASER_MAVENCENTRAL_USERNAME,JRELEASER_MAVENCENTRAL_PASSWORD,JRELEASER_GPG_PASSPHRASE,JRELEASER_GPG_PUBLIC_KEY,JRELEASER_GPG_SECRET_KEYTest plan
./gradlew clean buildpasses (compile + errorprone + tests + javadoc + spotless + license)./gradlew javadocpasses with zero warnings./gradlew publishproduces staging artifacts inbuild/staging-deployNote
Medium Risk
Medium risk because it changes artifact coordinates and the entire release/publishing pipeline (CI gating, signing, and deployment), which can break releases or downstream dependency resolution if misconfigured.
Overview
Switches distribution to Maven Central by changing published coordinates to
io.consensys.protocols:discovery, generating sources/javadoc jars via Gradle, updating POM metadata, and replacing Cloudsmith publishing with a local staging repo plusjreleaserMaven Central deployment.Modernizes build and CI by replacing
grgit-based versioning withgit-versioning, upgrading Error Prone +errorprone-checks, relaxing doclint to avoid missing-doc failures, and updating GitHub Actions to pinned SHAs with publish running only on tags using new JReleaser + GPG secrets. Minor hygiene:.factorypathignored and a couple of Javadoc generic references escaped.Written by Cursor Bugbot for commit 7bd640d. This will update automatically on new commits. Configure here.