Skip to content

Modified the integtest to support user-requested deletion of HDF5 files at the end of the integtest #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bieryAtFnal wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Modified the integtest to support user-requested deletion of HDF5 files at the end of the integtest #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9048996
Modified the integtest to support user-requested deletion of HDF5 fil…
May 21, 2026
113bff7
Updated the new cleanup test in iceberg_real_hsi_test.py to check for…
May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions integtest/iceberg_real_hsi_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@

import integrationtest.data_file_checks as data_file_checks
import integrationtest.log_file_checks as log_file_checks
import integrationtest.basic_checks as basic_checks
import integrationtest.data_classes as data_classes
import integrationtest.utility_functions as utility_functions
from integrationtest.verbosity_helper import IntegtestVerbosityLevels

import functools
Expand Down Expand Up @@ -148,7 +148,7 @@ def test_dunerc_success(run_dunerc, caplog):
pytest.skip(f"The connectivity service must be running for this test.")

# check for run control success, problems during pytest setup, etc.
basic_checks.basic_checks(run_dunerc, caplog, print_test_name=True)
utility_functions.basic_checks(run_dunerc, caplog, print_test_name=True)

def test_log_files(run_dunerc):
if not we_are_running_on_an_iceberg_computer:
Expand Down Expand Up @@ -197,3 +197,13 @@ def test_data_files(run_dunerc):

# ### also test the expected trigger bit ###


def test_cleanup(run_dunerc):
if not we_are_running_on_an_iceberg_computer:
pytest.skip(f"This computer ({hostname}) is not part of the ICEBERG DAQ cluster and therefore can not run this test.")
if not the_global_timing_session_is_running:
pytest.skip("The global timing session is not running.")
if not the_connection_server_is_running:
pytest.skip(f"The connectivity service must be running for this test.")

utility_functions.remove_hdf5_files_if_requested(run_dunerc, this_test_requests_hdf5_file_removal=False)
Loading