NUC BOX v0.9.2#879
Open
filipleple wants to merge 17 commits into
Open
Conversation
filipleple
changed the title
Member
Author
|
The fixes have been backported to the v0.9.0 release tag on nucbox_v0.9.1_oldbase |
This was referenced Apr 23, 2026
Comment on lines
+85
to
+86
| payload-swid-ready-dep := $(if $(wildcard $(payload-git-dir-y)/.git),$(payload-git-dir-y)/.git,) | ||
| ipxe-swid-ready-dep := $(if $(wildcard payloads/external/iPXE/ipxe/.git),payloads/external/iPXE/ipxe/.git,) |
Member
There was a problem hiding this comment.
Isn't wildcard doing the same with or without if in this case?
Suggested change
| payload-swid-ready-dep := $(if $(wildcard $(payload-git-dir-y)/.git),$(payload-git-dir-y)/.git,) | |
| ipxe-swid-ready-dep := $(if $(wildcard payloads/external/iPXE/ipxe/.git),payloads/external/iPXE/ipxe/.git,) | |
| payload-swid-ready-dep := $(wildcard $(payload-git-dir-y)/.git) | |
| ipxe-swid-ready-dep := $(wildcard payloads/external/iPXE/ipxe/.git) |
Member
|
|
||
| static void mainboard_enable(struct device *dev) | ||
| { | ||
| #if CONFIG(GENERATE_SMBIOS_TABLES) |
Member
There was a problem hiding this comment.
if (CONFIG(GENERATE_SMBIOS_TABLES)) didn't work for some reason?
Member
Author
There was a problem hiding this comment.
That was just being overly cautious, works after changing: 93deeea
filipleple
force-pushed
the
nuc091
branch
3 times, most recently
from
4807a60 to
9bc6189
Compare
Member
|
@filipleple, #889 is successfully addressing CI issues. |
Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Fixes the build-time dependencies to elliminate race conditions preparing SBOM in a parallel build. SBOM is generated only when all components are in place, and doesn't trigger any cloning/rebuilds. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Fixes the TPM2 recognition in Windows by ensuring consistent ACPI device path reconstruction Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Fixes ACPI code for proper S3 handling and USB wake enablement Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Because UEFI DBX keeps growing in size, and we have a lot of UEFI variables, we've run into an issue where there's not enough free space to update the DBX. Increase the SMMSTORE region to 512K to mitigate this issue. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Enable debug SMI, which works around issue Dasharo/dasharo-issues#1664. This is a workaround and should be removed once a proper solution to the issue is found. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Improve performance by lowering the EPP value from the power-on default of 0xb3 (70%) to 0x73 (45%). Lower value = higher performance. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Member
Author
@SergiiDmytruk right, thank you, saved me quite a bit of trouble 😅 |
Move mainboard_configure_gpios() from bootblock_mainboard_early_init() to mainboard_init() in ramstage. GPIO configuration does not need to run before DRAM is available and the full device tree context is present. Disable USE_LEGACY_8254_TIMER (required for s0ix/modern standby compatibility) and normalize SIO printk messages to a consistent "SIO: <action> (LDNx)" format. Inline the half_populated constant in the memcfg_init() call. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Required to build with SBOM support, otherwise go is missing Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
The GH runners have UID 1001, while user coreboot in SDK has id 1000. This creates a mismatch of IDs and causes permission problems when mounting coreboot git repository under /home/coreboot/coreboot in the container, because the /home/coreboot is a HOME directory of different user. To fix the problem, move the mountpoint to a "neutral" place, where permissions should not be a an issue. The /build directory is chosen so that it does not collide with any HOME directory or system directory. Upstream-Status: Inappropriate [Dasharo CI] Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
Move the mountpoint to /tmp, where permissions should not be a an issue. Upstream-Status: Inappropriate [Dasharo CI] Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
GCC 13 promotes -Wflex-array-member-not-at-end to an error. The bpm_ibbs and bpm_ibbs_bottom structs contain hash_struct members with flexible arrays that are not at the end of their containing struct. Their layout is fixed by the CBnT hardware specification and cannot be reordered. Suppress the diagnostic with a pragma guard around the affected struct definitions. These hash_struct fields are deprecated since CBnT BWG v1.2.0 and are always written with size=0 (no payload bytes). Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Member
Author
|
Looks like the only thing missing is an update of ME.bin in dasharo-blobs. |
$(wildcard ...) already returns an empty string when the path does not exist, so the $(if $(wildcard ...),x,) wrapper is redundant. Replace both payload-swid-ready-dep and ipxe-swid-ready-dep assignments with a plain $(wildcard ...) call. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
get_smbios_data is unconditionally present in struct device_operations, so a preprocessor guard is not needed. Replace #if CONFIG() / #endif with if (CONFIG()) so the compiler checks both branches. Upstream-Status: Pending Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release/RC are to be done branching from the last release tag for minimum testing effort. However, we want all fixes to be present on the "main" branch as well.
ref: NCM-2211