Bumps IpcClientTest timeout and update CI Vis CODEOWNERS#8873
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenchmarksBenchmark execution time: 2026-07-07 16:57:39 Comparing candidate commit b479d9e in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 71 metrics, 0 unstable metrics, 62 known flaky benchmarks, 64 flaky benchmarks without significant changes.
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8873) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8873) - mean (70ms) : 68, 72
master - mean (71ms) : 68, 73
section Bailout
This PR (8873) - mean (77ms) : 74, 80
master - mean (74ms) : 73, 75
section CallTarget+Inlining+NGEN
This PR (8873) - mean (1,083ms) : 1042, 1125
master - mean (1,089ms) : 1039, 1138
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8873) - mean (110ms) : 105, 115
master - mean (110ms) : 105, 115
section Bailout
This PR (8873) - mean (114ms) : 109, 120
master - mean (110ms) : 108, 112
section CallTarget+Inlining+NGEN
This PR (8873) - mean (777ms) : 757, 797
master - mean (783ms) : 759, 806
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8873) - mean (101ms) : 95, 106
master - mean (98ms) : 93, 103
section Bailout
This PR (8873) - mean (98ms) : 95, 102
master - mean (101ms) : 96, 106
section CallTarget+Inlining+NGEN
This PR (8873) - mean (940ms) : 891, 990
master - mean (936ms) : 900, 973
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8873) - mean (94ms) : 91, 98
master - mean (95ms) : 92, 97
section Bailout
This PR (8873) - mean (100ms) : 95, 105
master - mean (96ms) : 94, 98
section CallTarget+Inlining+NGEN
This PR (8873) - mean (814ms) : 768, 861
master - mean (816ms) : 773, 860
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8873) - mean (203ms) : 199, 207
master - mean (203ms) : 197, 209
section Bailout
This PR (8873) - mean (206ms) : 201, 211
master - mean (207ms) : 203, 211
section CallTarget+Inlining+NGEN
This PR (8873) - mean (1,214ms) : 1167, 1261
master - mean (1,213ms) : 1168, 1258
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8873) - mean (292ms) : 283, 300
master - mean (289ms) : 281, 298
section Bailout
This PR (8873) - mean (289ms) : 283, 295
master - mean (291ms) : 286, 295
section CallTarget+Inlining+NGEN
This PR (8873) - mean (975ms) : 951, 1000
master - mean (972ms) : 954, 991
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8873) - mean (286ms) : 280, 291
master - mean (282ms) : 275, 288
section Bailout
This PR (8873) - mean (284ms) : 279, 289
master - mean (279ms) : 273, 284
section CallTarget+Inlining+NGEN
This PR (8873) - mean (1,178ms) : 1146, 1209
master - mean (1,164ms) : 1125, 1203
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8873) - mean (285ms) : 277, 292
master - mean (277ms) : 270, 283
section Bailout
This PR (8873) - mean (288ms) : 279, 297
master - mean (274ms) : 266, 282
section CallTarget+Inlining+NGEN
This PR (8873) - mean (1,051ms) : 1005, 1097
master - mean (1,042ms) : 998, 1086
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Summary of changes
Increase the
IpcClientTesttimeout from 30s to 40s, and add a missing CODEOWNERS entry for the Ci unit test directory.Reason for change
IpcClientTestwas flaking with aTimeoutExceptioneven though both sides had reached the expected message countCircularChannelpolls every 100ms and the test needs ~40 round trips, so occasional CI scheduling delays can push it past 30s.tracer/test/Datadog.Trace.Tests/Ci/had no CODEOWNERS entryImplementation details
bumped the timeout to 40s
Added CI Vis to the owner
Test coverage
Same tests
Other details
#incident-57303