Move TestOptimizationFeatureTests to TracerInstanceTestCollection#8880
Draft
bouwkast wants to merge 1 commit into
Draft
Move TestOptimizationFeatureTests to TracerInstanceTestCollection#8880bouwkast wants to merge 1 commit into
bouwkast wants to merge 1 commit into
Conversation
bouwkast
added
area:tests
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8880) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (71ms) : 67, 74
master - mean (71ms) : 68, 73
section Bailout
This PR (8880) - mean (77ms) : 73, 80
master - mean (78ms) : 74, 83
section CallTarget+Inlining+NGEN
This PR (8880) - mean (1,081ms) : 1036, 1126
master - mean (1,085ms) : 1039, 1131
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (112ms) : 106, 117
master - mean (112ms) : 105, 119
section Bailout
This PR (8880) - mean (113ms) : 107, 119
master - mean (113ms) : 108, 117
section CallTarget+Inlining+NGEN
This PR (8880) - mean (780ms) : 751, 808
master - mean (774ms) : 751, 797
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (97ms) : 94, 99
master - mean (101ms) : 95, 106
section Bailout
This PR (8880) - mean (101ms) : 95, 107
master - mean (99ms) : 94, 103
section CallTarget+Inlining+NGEN
This PR (8880) - mean (939ms) : 899, 978
master - mean (939ms) : 894, 985
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (95ms) : 91, 99
master - mean (95ms) : 92, 97
section Bailout
This PR (8880) - mean (95ms) : 94, 97
master - mean (99ms) : 94, 104
section CallTarget+Inlining+NGEN
This PR (8880) - mean (813ms) : 766, 860
master - mean (814ms) : 775, 853
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (201ms) : 196, 206
master - mean (203ms) : 196, 210
section Bailout
This PR (8880) - mean (204ms) : 200, 209
master - mean (207ms) : 202, 212
section CallTarget+Inlining+NGEN
This PR (8880) - mean (1,205ms) : 1165, 1246
master - mean (1,222ms) : 1177, 1268
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (288ms) : 280, 295
master - mean (291ms) : 284, 299
section Bailout
This PR (8880) - mean (289ms) : 282, 296
master - mean (292ms) : 283, 301
section CallTarget+Inlining+NGEN
This PR (8880) - mean (966ms) : 950, 981
master - mean (977ms) : 947, 1007
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (281ms) : 276, 286
master - mean (285ms) : 278, 291
section Bailout
This PR (8880) - mean (281ms) : 276, 286
master - mean (284ms) : 278, 290
section CallTarget+Inlining+NGEN
This PR (8880) - mean (1,167ms) : 1125, 1209
master - mean (1,172ms) : 1134, 1209
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8880) - mean (278ms) : 272, 285
master - mean (283ms) : 276, 290
section Bailout
This PR (8880) - mean (278ms) : 272, 284
master - mean (283ms) : 276, 290
section CallTarget+Inlining+NGEN
This PR (8880) - mean (1,045ms) : 995, 1095
master - mean (1,051ms) : 1002, 1101
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-07-08 20:49:16 Comparing candidate commit ebe5d8c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 61 known flaky benchmarks, 65 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This puts TestOptimizationFeatureTests in the same non-parallel collection as TestSessionCoverageTests, so it can no longer null the CIVisibilityItrCoverageBackfillRunFolder mid-test and cause flake in the tests.
Reason for change
Needs to run synchronously as they mutate the
TestOptimization.Instance.Tests flaked for
CloseDoesNotPublishPersistedCoverageWhenPersistedCoverageIpcSnapshotIsIncompletewithDid not expect a value, but found 80.0.which was caused by other tests.Implementation details
Moved the collection to
[Collection(nameof(TracerInstanceTestCollection))]Test coverage
Other details
#incident-57303