Avoid excessive BuggyBits exceptions in endpoint tests#8881
Open
bouwkast wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
@codex review |
github-actions
Bot
added
the
area:profiler
bouwkast
added
type:flake-fix
area:tests
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8881) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8881) - mean (70ms) : 68, 72
master - mean (70ms) : 68, 72
section Bailout
This PR (8881) - mean (74ms) : 72, 75
master - mean (74ms) : 73, 76
section CallTarget+Inlining+NGEN
This PR (8881) - mean (1,084ms) : 1034, 1133
master - mean (1,084ms) : 1029, 1139
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8881) - mean (111ms) : 99, 124
master - mean (109ms) : 106, 112
section Bailout
This PR (8881) - mean (110ms) : 108, 112
master - mean (110ms) : 107, 113
section CallTarget+Inlining+NGEN
This PR (8881) - mean (778ms) : 754, 801
master - mean (780ms) : 752, 809
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8881) - mean (96ms) : 94, 98
master - mean (101ms) : 94, 107
section Bailout
This PR (8881) - mean (101ms) : 96, 106
master - mean (98ms) : 94, 102
section CallTarget+Inlining+NGEN
This PR (8881) - mean (936ms) : 899, 972
master - mean (934ms) : 894, 973
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8881) - mean (95ms) : 90, 101
master - mean (94ms) : 92, 97
section Bailout
This PR (8881) - mean (95ms) : 94, 97
master - mean (95ms) : 93, 97
section CallTarget+Inlining+NGEN
This PR (8881) - mean (813ms) : 778, 849
master - mean (817ms) : 783, 851
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8881) - mean (202ms) : 196, 207
master - mean (202ms) : 196, 208
section Bailout
This PR (8881) - mean (206ms) : 200, 212
master - mean (205ms) : 202, 208
section CallTarget+Inlining+NGEN
This PR (8881) - mean (1,211ms) : 1164, 1257
master - mean (1,206ms) : 1162, 1251
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8881) - mean (292ms) : 285, 298
master - mean (291ms) : 284, 299
section Bailout
This PR (8881) - mean (292ms) : 284, 299
master - mean (291ms) : 283, 298
section CallTarget+Inlining+NGEN
This PR (8881) - mean (977ms) : 959, 996
master - mean (974ms) : 949, 999
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8881) - mean (283ms) : 277, 289
master - mean (283ms) : 275, 290
section Bailout
This PR (8881) - mean (284ms) : 277, 290
master - mean (283ms) : 278, 287
section CallTarget+Inlining+NGEN
This PR (8881) - mean (1,169ms) : 1137, 1202
master - mean (1,169ms) : 1133, 1206
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8881) - mean (281ms) : 275, 287
master - mean (281ms) : 275, 287
section Bailout
This PR (8881) - mean (281ms) : 275, 286
master - mean (278ms) : 271, 285
section CallTarget+Inlining+NGEN
This PR (8881) - mean (1,045ms) : 996, 1095
master - mean (1,043ms) : 991, 1095
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BenchmarksBenchmark execution time: 2026-07-08 21:43:47 Comparing candidate commit 9cc38af in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 72 metrics, 0 unstable metrics, 60 known flaky benchmarks, 66 flaky benchmarks without significant changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds a dedicated BuggyBits endpoint profiling scenario and updates the CodeHotspot endpoint tests to use it instead of the sales scenario.
Reason for change
Over the past week(ish) BuggyBits has crashed several times during CodeHotspotTests and it appears that it was caused by it re-using an endpoint (
--scenario 16) which called the /Sales endpoint which intentially throws significant number of exceptions per request and appeared to be crashing the sample.Implementation details
SelfInvokerto call that new endpointCodeHotspotTeststo use that new scenario and endpointTest coverage
Other details
#incident-57303