Skip to content

feat: Add FFI for trace exporter #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 15 commits into from
May 26, 2026
Merged

feat: Add FFI for trace exporter #1952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
031b40e
Add `TracerSpan` FFI for field-by-field span construction
lloeki May 6, 2026
1d7879d
Add `TracerTraceChunks` FFI for grouping spans into traces
lloeki May 6, 2026
977c75f
Add `ddog_trace_exporter_send_trace_chunks` FFI function
lloeki May 6, 2026
ced27fb
Use `map_err` in `charslice_to_bytesstring`
lloeki May 7, 2026
45900d3
Make `TracerSpan` and `TracerTraceChunks` inner fields private
lloeki May 7, 2026
e728408
Simplify `ddog_tracer_trace_chunks_new` capacity handling
lloeki May 7, 2026
19bf03e
Use `let-else` for null exporter check in `ddog_trace_exporter_send_t…
lloeki May 7, 2026
b2fa5a6
Make test helpers safe functions with internal `unsafe` blocks
lloeki May 7, 2026
61a13fe
Use inner closure with `?` operator in `ddog_tracer_span_new`
lloeki May 7, 2026
e709e7a
Use `&mut MaybeUninit<Box<T>>` for out-parameters
lloeki May 7, 2026
9b72f68
Revert to `NonNull<Box<T>>` for out-parameters
lloeki May 13, 2026
9967542
Introduce `TracerSpanFields` struct for `ddog_tracer_span_new`
lloeki May 13, 2026
1e8bc64
Add `capacity` parameter to `ddog_tracer_trace_chunks_begin_chunk`
lloeki May 13, 2026
b9ea727
Add error return and null handle check to `ddog_tracer_trace_chunks_b…
lloeki May 13, 2026
693a1ca
Empty (CI trigger)
lloeki May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libdd-data-pipeline-ffi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,5 @@ libdd-data-pipeline = { path = "../libdd-data-pipeline" }
libdd-shared-runtime = { version = "1.0.0", path = "../libdd-shared-runtime" }
libdd-common-ffi = { path = "../libdd-common-ffi", default-features = false }
libdd-tinybytes = { path = "../libdd-tinybytes" }
libdd-trace-utils = { path = "../libdd-trace-utils" }
tracing = { version = "0.1", default-features = false }
9 changes: 7 additions & 2 deletions libdd-data-pipeline-ffi/cbindgen.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ include_guard = "DDOG_DATA_PIPELINE_H"
includes = ["common.h"]
after_includes = """
typedef struct ddog_TraceExporter ddog_TraceExporter;
typedef struct ddog_TracerSpan ddog_TracerSpan;
typedef struct ddog_TracerTraceChunks ddog_TracerTraceChunks;
"""

[export]
prefix = "ddog_"
renaming_overrides_prefixing = true
exclude = ["TraceExporter"]
exclude = ["TraceExporter", "TracerSpan", "TracerTraceChunks"]

[export.rename]
"ByteSlice" = "ddog_ByteSlice"
Expand All @@ -27,6 +29,9 @@ exclude = ["TraceExporter"]
"ExporterResponse" = "ddog_TraceExporterResponse"
"ExporterErrorCode" = "ddog_TraceExporterErrorCode"
"ExporterError" = "ddog_TraceExporterError"
"TracerSpan" = "ddog_TracerSpan"
"TracerSpanFields" = "ddog_TracerSpanFields"
"TracerTraceChunks" = "ddog_TracerTraceChunks"

[export.mangle]
rename_types = "PascalCase"
Expand All @@ -40,4 +45,4 @@ must_use = "DDOG_CHECK_RETURN"

[parse]
parse_deps = true
include = ["libdd-common", "libdd-common-ffi", "libdd-shared-runtime", "libdd-data-pipeline"]
include = ["libdd-common", "libdd-common-ffi", "libdd-shared-runtime", "libdd-data-pipeline", "libdd-trace-utils"]
1 change: 1 addition & 0 deletions libdd-data-pipeline-ffi/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
mod error;
mod response;
mod trace_exporter;
mod tracer;

#[cfg(all(feature = "catch_panic", panic = "unwind"))]
macro_rules! catch_panic {
Expand Down
2 changes: 1 addition & 1 deletion libdd-data-pipeline-ffi/src/trace_exporter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use libdd_data_pipeline::trace_exporter::{
TraceExporterInputFormat, TraceExporterOutputFormat,
};

type TraceExporter = GenericTraceExporter<NativeCapabilities>;
pub(crate) type TraceExporter = GenericTraceExporter<NativeCapabilities>;

use libdd_shared_runtime::SharedRuntime;
use std::{ptr::NonNull, sync::Arc, time::Duration};
Expand Down
Loading
Loading