Skip to content

support Node.js v26 #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IlyasShabi merged 2 commits into from
May 18, 2026
Merged

support Node.js v26 #327

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac3b673
support Node.js v26
IlyasShabi May 18, 2026
031aa12
remove v26 from benchmark
IlyasShabi May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
asan:
strategy:
matrix:
version: [18, 20, 22, 24, 25]
version: [18, 20, 22, 24, 25, 26]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand All @@ -23,7 +23,7 @@ jobs:
valgrind:
strategy:
matrix:
version: [18, 20, 22, 24, 25]
version: [18, 20, 22, 24, 25, 26]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions .gitlab/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ benchmarks:
- MAJOR_NODE_VERSION: 22
- MAJOR_NODE_VERSION: 24
- MAJOR_NODE_VERSION: 25
- MAJOR_NODE_VERSION: 26
artifacts:
name: "reports"
paths:
Expand Down
11 changes: 10 additions & 1 deletion bindings/profilers/wall.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,15 @@ class PersistentContextPtr : public node::ObjectWrap {
}
};

inline void* GetAlignedPointerFromInternalField(Object* object, int index) {
#if NODE_MAJOR_VERSION >= 26
return object->GetAlignedPointerFromInternalField(
index, kEmbedderDataTypeTagDefault);
#else
return object->GetAlignedPointerFromInternalField(index);
#endif
}

// Maximum number of rounds in the GetV8ToEpochOffset
static constexpr int MAX_EPOCH_OFFSET_ATTEMPTS = 20;

Expand Down Expand Up @@ -1274,7 +1283,7 @@ ContextPtr WallProfiler::GetContextPtr(Isolate* isolate) {
auto wrapObj = reinterpret_cast<Object*>(wrapValue);
if (wrapObj->InternalFieldCount() > 0) {
return static_cast<PersistentContextPtr*>(
wrapObj->GetAlignedPointerFromInternalField(0))
GetAlignedPointerFromInternalField(wrapObj, 0))
->Get();
}
}
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"gts": "^7.0.0",
"js-green-licenses": "^4.0.0",
"mocha": "^11.7.5",
"nan": "^2.26.2",
"nan": "^2.27.0",
"nyc": "^18.0.0",
"semver": "^7.8.0",
"sinon": "^22.0.0",
Expand Down
Loading