Skip to content

[docker_ssi] activate test_injection_metadata #7027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annacai21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[docker_ssi] activate test_injection_metadata #7027

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions tests/docker_ssi/test_docker_ssi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
context,
irrelevant,
bug,
missing_feature,
interfaces,
weblog,
logger,
Expand Down Expand Up @@ -164,7 +163,6 @@ def setup_injection_metadata(self):
self._setup_all()

@features.ssi_injection_metadata
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate activation on the injector version

This now runs the assertion for every datadog-apm-inject package, but the required early result == "starting" record is an injector feature, not a tracer feature. I checked the Docker SSI workflow path: utils/scripts/ci_orchestrators/gitlab_exporter.py forwards DD_INSTALLER_INJECTOR_VERSION as --ssi-injector-version, and utils/build/ssi/base/install_script_ssi.sh installs that exact datadog-apm-inject version, so auto-inject or release pipelines that exercise a version before auto_inject#1075 will hit this test and fail on the missing starting event instead of being marked missing-feature. Please keep this xfail conditional on context.dd_apm_inject_version or add the equivalent manifest coverage for older injector versions.

Useful? React with 👍 / 👎.

@missing_feature(reason="auto_inject#1075 adds early 'starting' injection-metadata event; not yet released")
@irrelevant(context.library == "python" and context.installed_language_runtime < "3.8.0")
@irrelevant(context.library == "java" and context.installed_language_runtime < "1.8.0_0")
@irrelevant(context.library == "php" and context.installed_language_runtime < "7.1")
Expand Down
Loading