Skip to content

T1331067 - Vertical lines don't work with multiple axes and panes #34115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmlvr merged 3 commits into from
Jun 26, 2026
+34 −1
Merged

T1331067 - Vertical lines don't work with multiple axes and panes #34115

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb507a3
fix bug and write test
dmlvr Jun 24, 2026
179146e
update test
dmlvr Jun 24, 2026
a48876d
remove try-cath construction from test
dmlvr Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devextreme/js/__internal/viz/axes/base_axis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,7 +997,7 @@ Axis.prototype = {
that._setTickOffset();

that._isHorizontal = options.isHorizontal;
that.pane = options.pane;
that.pane = options.pane ?? that.pane;
that.name = options.name;
that.priority = options.priority;

Expand Down
37 changes: 37 additions & 0 deletions packages/devextreme/testing/tests/DevExpress.viz.charts/chart.integration.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2015,6 +2015,43 @@ QUnit.test('Validate Axis on update', function(assert) {
assert.strictEqual(chart.getArgumentAxis().getOptions().type, 'continuous');
});

QUnit.test('Constant lines dynamic update with automatically created value axis (T891599)', function(assert) {
const chart = this.createChart({
dataSource: [
{ t: new Date(2026, 5, 16), val1: 14.13, val2: 0, val3: 12 }
],
commonSeriesSettings: {
argumentField: 't'
},
panes: [
{ name: 'pane1' },
{ name: 'pane2' },
{ name: 'pane3' }
],
series: [
{ axis: 'ax_1', pane: 'pane1', type: 'line', valueField: 'val1' },
{ axis: 'ax_2', pane: 'pane2', type: 'line', valueField: 'val2' },
{ axis: 'ax_3', pane: 'pane3', type: 'line', valueField: 'val3' }
],
valueAxis: [
{ name: 'ax_1' },
{ name: 'ax_2' }
],
argumentAxis: {
argumentType: 'datetime',
constantLines: [{ value: new Date(2026, 5, 16) }]
}
});

try {
chart.option('argumentAxis.constantLines', [{ value: new Date(2026, 5, 16) }]);
assert.ok(true, 'no error during update');
} catch(e) {
assert.ok(false, 'error: ' + e.message);
}
});
Comment thread
pharret31 marked this conversation as resolved.


// T951843
QUnit.test('Chart can hide series on done event', function(assert) {
const drawn = sinon.spy();
Expand Down
Loading