Skip to content

ELM-side changes for outputting biophysics variables by land use type#7783

Merged
peterdschwartz merged 8 commits into
E3SM-Project:masterfrom
ckoven:fates_pr_1407
Mar 25, 2026
Merged

ELM-side changes for outputting biophysics variables by land use type#7783
peterdschwartz merged 8 commits into
E3SM-Project:masterfrom
ckoven:fates_pr_1407

Conversation

@ckoven
Copy link
Copy Markdown
Contributor

@ckoven ckoven commented Oct 10, 2025

This pull request passes HLM biophysical landuse variables into fates to by output as diagnostic variables along FATES dimensions. Thefates_cold_luh2 test mod is updated to include these new diagnostic variables. This also updates the fates_cold_allvars testmod to include new history variables added with NGEET/fates#1485.

This PR is the ELM-side code changes associated with FATES PR NGEET/fates#1536.

[non-BFB] for FATES due to field lists

@glemieux
Copy link
Copy Markdown
Contributor

This pull request should come in after #7954

@glemieux glemieux marked this pull request as ready for review February 27, 2026 22:37
@glemieux glemieux requested a review from rgknox February 27, 2026 22:37
@glemieux
Copy link
Copy Markdown
Contributor

@rgknox this is ready for review. I'm going to kick off fates and e3sm_land_developer tests on perlmutter once my baselines are completed.

@glemieux
Copy link
Copy Markdown
Contributor

glemieux commented Mar 2, 2026

Regression testing the fates testmod list against the baseline for sci.1.90.1_api.43.1.0 is B4B with the expected exception of FIELDLIST differences in the luh2 testmods and the allvars testmods.

@glemieux
Copy link
Copy Markdown
Contributor

glemieux commented Mar 2, 2026

Regression testing the e3sm_land_developer list on pm-cpu against the master baseline is underway.

@rljacob rljacob added the ELM land model label Mar 3, 2026
Copy link
Copy Markdown
Contributor

@rgknox rgknox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is straight forward and sensible, thanks for submitting

@glemieux glemieux moved this from Finding Reviewers to Final Testing in FATES Pull Request Planning and Status Mar 9, 2026
@glemieux
Copy link
Copy Markdown
Contributor

glemieux commented Mar 9, 2026

Re-running e3sm_land_developer regression tests post fates-side update and rebasing against master.

@glemieux
Copy link
Copy Markdown
Contributor

Re-running e3sm_land_developer regression tests post fates-side update and rebasing against master.

Regression testing on perlmutter against master baseline is B4B with the expected NLCOMP diffs for a subset of the fates test.

@peterdschwartz I'll give you a ping once we've integrated the fates side and after I've updated the commit hash here.

@glemieux glemieux moved this from Final Testing to Ready to Integrate in FATES Pull Request Planning and Status Mar 10, 2026
@glemieux
Copy link
Copy Markdown
Contributor

@peterdschwartz this is good to integrate.

@rljacob
Copy link
Copy Markdown
Member

rljacob commented Mar 24, 2026

@peterdschwartz please start merging this.

peterdschwartz added a commit that referenced this pull request Mar 24, 2026
This pull request passes HLM biophysical landuse variables into fates to by output as diagnostic variables along FATES dimensions.
Thefates_cold_luh2 test mod is updated to include these new diagnostic variables.
This also updates the fates_cold_allvars testmod to include new history variables added with NGEET/fates#1485.

This PR is the ELM-side code changes associated with FATES PR NGEET/fates#1536.

[B4B]
@peterdschwartz
Copy link
Copy Markdown
Contributor

merged to next

@peterdschwartz peterdschwartz merged commit d72fcbc into E3SM-Project:master Mar 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ELM land model FATES

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants