Docs photosynthetic capacity update#3958
Merged
samsrabin merged 8 commits intoESCOMP:b4b-devfrom May 7, 2026
Merged
Conversation
1 task
❌ Docs build failedBuild logs |
Member
|
(I'll handle the build errors during my review.) |
samsrabin
reviewed
Apr 30, 2026
❌ Docs build failedBuild logs |
samsrabin
reviewed
Apr 30, 2026
8 tasks
samsrabin
requested changes
Apr 30, 2026
Member
samsrabin
left a comment
There was a problem hiding this comment.
Looks great! Just some minor requests/suggestions.
Contributor
|
@adrifoster what do you think: I could make revisions to the PR and get it ready for merge if you agree. |
Contributor
Author
sorry will work on these now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Updates to the Photosynthetic Capacity section (section 2.10) of the Tech Note. Includes some math and typo updates as well as an update on parameter values since these have mostly changed since CLM5.
Specific notes
Also updated references and added new ones.
@linniahawkins we might want to add which parameters are now pft-specific?
Contributors other than yourself, if any: @linniahawkins @samsrabin
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? yes and yes
Testing performed, if any: