Skip to content

Docs photosynthetic capacity update#3958

Merged
samsrabin merged 8 commits intoESCOMP:b4b-devfrom
adrifoster:docs_photosynthetic_capacity_update
May 7, 2026
Merged

Docs photosynthetic capacity update#3958
samsrabin merged 8 commits intoESCOMP:b4b-devfrom
adrifoster:docs_photosynthetic_capacity_update

Conversation

@adrifoster
Copy link
Copy Markdown
Contributor

@adrifoster adrifoster commented Apr 23, 2026

Description of changes

Updates to the Photosynthetic Capacity section (section 2.10) of the Tech Note. Includes some math and typo updates as well as an update on parameter values since these have mostly changed since CLM5.

Specific notes

Also updated references and added new ones.

@linniahawkins we might want to add which parameters are now pft-specific?

Contributors other than yourself, if any: @linniahawkins @samsrabin

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? yes and yes

Testing performed, if any:

@wwieder wwieder requested a review from samsrabin April 30, 2026 17:05
@wwieder wwieder added documentation additions or edits to user-facing documentation or its infrastructure b4b bit-for-bit docs-loc:tech-note Relates to Technical Note (science) labels Apr 30, 2026
@github-actions
Copy link
Copy Markdown

❌ Docs build failed

Build logs
Cleaning documentation build directory...
Done.
Building documentation...
/home/user/mounted_home/doc/source/tech_note/Dust/CLM50_Tech_Note_Dust.rst:211: WARNING: undefined label: 'comolaetal2019' [ref.ref]
/home/user/mounted_home/doc/source/tech_note/Dust/CLM50_Tech_Note_Dust.rst:213: WARNING: undefined label: 'comolaetal2019' [ref.ref]
WARNING: The requested image's platform (linux/amd64/v8) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested
Documentation build completed, but with problems that must be resolved.
Re-run with --verbose for full output.

@samsrabin
Copy link
Copy Markdown
Member

(I'll handle the build errors during my review.)

Comment thread doc/source/tech_note/References/CLM50_Tech_Note_References.rst
@github-actions
Copy link
Copy Markdown

❌ Docs build failed

Build logs
Cleaning documentation build directory...
Done.
Building documentation...
/home/user/mounted_home/doc/source/tech_note/Dust/CLM50_Tech_Note_Dust.rst:211: WARNING: undefined label: 'comolaetal2019' [ref.ref]
/home/user/mounted_home/doc/source/tech_note/Dust/CLM50_Tech_Note_Dust.rst:213: WARNING: undefined label: 'comolaetal2019' [ref.ref]
/home/user/mounted_home/doc/source/tech_note/Surface_Albedos/CLM50_Tech_Note_Surface_Albedos.rst:351: WARNING: undefined label: 'majasalmibright2019' [ref.ref]
WARNING: The requested image's platform (linux/amd64/v8) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested
Documentation build completed, but with problems that must be resolved.
Re-run with --verbose for full output.

Comment thread doc/source/tech_note/References/CLM50_Tech_Note_References.rst
@ESCOMP ESCOMP deleted a comment from github-actions Bot Apr 30, 2026
@samsrabin samsrabin moved this to In Progress in CLM documentation Apr 30, 2026
@samsrabin samsrabin linked an issue Apr 30, 2026 that may be closed by this pull request
8 tasks
@samsrabin samsrabin added this to the CESM Workshop milestone Apr 30, 2026
@samsrabin samsrabin added the docs:minor-content-fix Small fix needed to (or improvement suggested in) documentation content label Apr 30, 2026
Copy link
Copy Markdown
Member

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some minor requests/suggestions.

@slevis-lmwg
Copy link
Copy Markdown
Contributor

@adrifoster what do you think: I could make revisions to the PR and get it ready for merge if you agree.

@adrifoster
Copy link
Copy Markdown
Contributor Author

@adrifoster what do you think: I could make revisions to the PR and get it ready for merge if you agree.

sorry will work on these now

Copy link
Copy Markdown
Member

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samsrabin samsrabin merged commit 0814179 into ESCOMP:b4b-dev May 7, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in CLM documentation May 7, 2026
@slevis-lmwg slevis-lmwg mentioned this pull request May 7, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit docs:minor-content-fix Small fix needed to (or improvement suggested in) documentation content docs-loc:tech-note Relates to Technical Note (science) documentation additions or edits to user-facing documentation or its infrastructure

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Review 2.10. Photosynthetic Capacity

4 participants