Revision of section 2.12 (Lake Model) in technical note for CLM6#3997
Revision of section 2.12 (Lake Model) in technical note for CLM6#3997nmizukami wants to merge 4 commits intoESCOMP:b4b-devfrom
Conversation
ekluzek
left a comment
There was a problem hiding this comment.
The changes make sense to me. And cover the things talked about. Removal of the section about updates since the previous version is good.
@nmizukami changed so that equations have equation before it, which makes sense to me. He questioned if that's a good change. But, I think we should go with it. It might be something to look at later for consistency between chapters.
|
@nmizukami , during my review of and changes to the Surface Albedo chapter, I found that the description of lake albedos was outdated (it referred to the prescribed lake albedos from LSM). So I changed this in the Surface Albedo chapter to follow the current code for lake albedo. I'd suggest then to simply refer to the Surface Albedo chapter (specifically Section 2.3.2 Ground Albedos) in the lake chapter. That way we don't duplicate the text/equations. I think the Ground Albedo section is appropriate since it describes albedos for the different surface types. |
|
@nmizukami this failed the checker in regard to curly quotes (since Sphynx will handle this). So you'll need to fix that before it can be merged. This should be straightforward, but I can show you if you have any questions. |
|
You can see the offending curlies here. I'm removing myself as reviewer since this isn't my bailiwick. |
Description of changes
After review, I made a few minor edits and various corrections e.g., links, equations. etc. I did not change anything on roughness length update made by @olyson.
Specific changes I made:
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #): Resolve #3858
Are answers expected to change (and if so in what way)? N/A
Any User Interface Changes (namelist or namelist defaults changes)? N/A
Does this create a need to change or add documentation? Did you do so? Yes, This PR is for documentation change.
Testing performed, if any:
Built documentation on Casper (NCAR HPC) following the working with documentation guide, no errors.