Skip to content

fix: sanitize subprocess call in rtl_ltr_linter.py#13254

Open
orbisai0security wants to merge 1 commit into
EbookFoundation:mainfrom
orbisai0security:fix-v-002-scripts-rtl-ltr-linter.py
Open

fix: sanitize subprocess call in rtl_ltr_linter.py#13254
orbisai0security wants to merge 1 commit into
EbookFoundation:mainfrom
orbisai0security:fix-v-002-scripts-rtl-ltr-linter.py

Conversation

@orbisai0security

Copy link
Copy Markdown

Summary

Fix high severity security issue in scripts/rtl_ltr_linter.py.

Vulnerability

Field Value
ID V-002
Severity HIGH
Scanner multi_agent_ai
Rule V-002
File scripts/rtl_ltr_linter.py:65
CWE CWE-78

Description: At line 69, a user-supplied or externally loaded configuration dictionary (conf) is merged directly into the default configuration using Python's dict.update() method without any key allowlisting or value validation. This means any key in the default configuration can be overridden by an attacker who can influence the configuration source. If configuration values downstream influence subprocess command construction (line 426) or file path handling, this becomes a vector for command injection or path traversal.

Changes

  • scripts/rtl_ltr_linter.py

Verification

  • Build passes
  • Scanner re-scan confirms fix
  • LLM code review passed

Automated security fix by OrbisAI Security

At line 69, a user-supplied or externally loaded configuration dictionary (conf) is merged directly into the default configuration using Python's dict
@github-actions

Copy link
Copy Markdown

'This Pull Request has been automatically marked as stale because it has not had recent activity during last 60 days 😴

It will be closed in 30 days if no further activity occurs. To unstale this PR, draft it, remove stale label, comment with a detailed explanation or push more commits.

There can be many reasons why some specific PR has no activity. The most probable cause is lack of time, not lack of interest.

Thank you for your patience ❤️'

@github-actions github-actions Bot added the stale Requests that have not had recent interaction (Out-of-Date) label Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Requests that have not had recent interaction (Out-of-Date)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant