You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think JQuery should really be removed from the backend rather than updated.
The file index.xql could easily be removed completely since it's not needed anymore?
And the Javascript in data/xql/getAudioPlayer.xql should be rewritten to get rid of JQuery.
I think JQuery should really be removed from the backend rather than updated. The file index.xql could easily be removed completely since it's not needed anymore? And the Javascript in data/xql/getAudioPlayer.xql should be rewritten to get rid of JQuery.
Just my 2c …
what about updating for this release, but prepare a new issue to get rid of JQuery completely until the next one?
This needs some testing with edition data that uses the old getAudioPlayer.xql (e.g Freischütz). So I think it's good to do it for the release 1.5.0 which is about reducing dependencies and cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
Updates jQuery references in the backend to version 4.0.0, consistent with
the frontend update, see Edirom-Online-Frontend: PR226).
Two separate backend files loaded different outdated jQuery versions:
not exist — jQuery was silently not loading in this context)
Both are replaced with a CDN reference to 4.0.0.
Refs Edirom/Edirom-Online-Frontend#187
How Has This Been Tested?
Types of changes
Overview