Skip to content

Making dynamic taxonomies backwards-compatible#196

Open
daniel-jettka wants to merge 1 commit into
some-fixesfrom
ftr/dynamic-taxonomies-backwards-compatible
Open

Making dynamic taxonomies backwards-compatible#196
daniel-jettka wants to merge 1 commit into
some-fixesfrom
ftr/dynamic-taxonomies-backwards-compatible

Conversation

@daniel-jettka

@daniel-jettka daniel-jettka commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Description, Context and related Issue

This introduces an optional GET parameter "mode".
If set to "taxonomies" the results of several xql endpoints return a result specific for the dynamic taxonomies feature introduced in #83

refs #186
related frontend PR: Edirom/Edirom-Online-Frontend#234

How Has This Been Tested?

together with frontend:
(a) frontend's develop branch which makes requests w/o mode param
(b) frontend's ftr/dynamic-taxonomies-backwards-compatible branch which makes requests with mode param

Types of changes

  • Improvement
  • Refactoring

Overview

  • I have updated the inline documentation accordingly.
  • I have performed a self-review of my code, according to the style guide
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes at tests
  • All new and existing tests passed.

@daniel-jettka

Copy link
Copy Markdown
Contributor Author

Maybe the <entry key="annotation_hide_legacy_fields" value="false"/> gets also obsolete with this as one can decide on calling the old or the "new" endpoint?!

<entry key="annotation_hide_legacy_fields" value="false"/>

@bwbohl

bwbohl commented Jul 13, 2026

Copy link
Copy Markdown
Member

milestone 1.5.0 ?

@bwbohl

bwbohl commented Jul 13, 2026

Copy link
Copy Markdown
Member

should this stil go in?

@daniel-jettka daniel-jettka added this to the 1.5.0 milestone Jul 13, 2026
@daniel-jettka

Copy link
Copy Markdown
Contributor Author

Thanks @bwbohl I updated the milestone to v1.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants