Skip to content

Renamed fields to remove naming redundancy. #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EranBoudjnah merged 1 commit into from
Apr 14, 2025
Merged

Renamed fields to remove naming redundancy. #405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...ntation-test/src/main/java/com/mitteloupe/whoami/test/server/response/SequenceResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@ package com.mitteloupe.whoami.test.server.response
import com.mitteloupe.whoami.test.server.ResponseBinder
import com.mitteloupe.whoami.test.server.ServerResponse

class SequenceResponse(private vararg val mockResponses: MockResponseContents) :
MockResponseContents {
class SequenceResponse(private vararg val responses: MockResponseContents) : MockResponseContents {
private var responseIndex = 0
override fun mockResponse(responseBinder: ResponseBinder): ServerResponse {
val mockResponse = mockResponses[responseIndex]
val mockResponse = responses[responseIndex]
responseIndex++
if (responseIndex == mockResponses.size) {
if (responseIndex == responses.size) {
responseIndex = 0
}
return mockResponse.mockResponse(responseBinder)
Expand Down
12 changes: 4 additions & 8 deletions ...mentation-test/src/main/java/com/mitteloupe/whoami/test/server/response/SimpleResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,18 @@ import com.mitteloupe.whoami.test.server.ResponseBinder
import com.mitteloupe.whoami.test.server.ServerResponse

data class SimpleResponse(
private val responseCode: Int = 200,
private val code: Int = 200,
private val bodyFileName: String = "",
private val headers: List<Pair<String, String>> = emptyList()
) : MockResponseContents {

private val responseBody by lazy {
private val body by lazy {
if (bodyFileName.isEmpty()) {
""
} else {
assetReader.getAssetAsString(bodyFileName)
}
}

override fun mockResponse(responseBinder: ResponseBinder) = ServerResponse(
code = responseCode,
headers = headers,
body = responseBody
)
override fun mockResponse(responseBinder: ResponseBinder) =
ServerResponse(code = code, headers = headers, body = body)
}