Invoke default action when swaync-client --action is called without an index#712
Open
bakhtiyarneyman wants to merge 3 commits intoErikReider:mainfrom
Open
Invoke default action when swaync-client --action is called without an index#712bakhtiyarneyman wants to merge 3 commits intoErikReider:mainfrom
swaync-client --action is called without an index#712bakhtiyarneyman wants to merge 3 commits intoErikReider:mainfrom
Conversation
… an index Previously, `--action` without an index would call `click_alt_action(0)`, which silently did nothing if the alt actions box wasn't visible. Now it invokes the notification's default action instead, matching user expectations. When an index is provided, the existing alt action behavior is preserved. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…vior Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ritiek
added a commit
to ritiek/dotfiles
that referenced
this pull request
Apr 4, 2026
ErikReider
requested changes
Apr 5, 2026
Comment on lines
+82
to
+83
| print (" -a, \t --action [ACTION_INDEX]\t " + | ||
| "Invokes the action [ACTION_INDEX] of the latest notification\n"); | ||
| "Invokes the default action, or action [ACTION_INDEX], of the latest notification\n"); |
Owner
There was a problem hiding this comment.
Might be better if an --action-default (or something similar) command was added instead. This wouldn't break existing configs.
Author
There was a problem hiding this comment.
Done, please take another look.
Per reviewer feedback, keep --action's original behavior (default to action index 0) and add a separate --action-default / -ad command to invoke the default action of the latest notification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
--actionwithout an index would callclick_alt_action(0), which silently did nothing if the alt actions box wasn't visible. Now it invokes the notification's default action instead, matching user expectations. When an index is provided, the existing alt action behavior is preserved. Please note, that this is a breaking change: users might need to change their scripts.