Use meson config_path as fallback instead of hardcoded /usr/local#727
Open
ljdi wants to merge 1 commit intoErikReider:mainfrom
Open
Use meson config_path as fallback instead of hardcoded /usr/local#727ljdi wants to merge 1 commit intoErikReider:mainfrom
ljdi wants to merge 1 commit intoErikReider:mainfrom
Conversation
The hardcoded fallback path /usr/local/etc/xdg/swaync/ breaks installs with custom prefixes (e.g. ~/.local). Use the meson build-time config_path to dynamically set the correct fallback. Fixes: ErikReider#726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #726
The hardcoded fallback path
/usr/local/etc/xdg/swaync/insrc/functions.valabreaks installations with custom prefixes (e.g.~/.local, FreeBSD's/usr/local, NetBSD's/usr/pkg).This PR injects the meson
config_path(resolved at build time) into the Vala source as a compile-time constant, replacing the hardcoded fallback in bothget_style_path()andget_config_path().Related: #4, #167, #168