[NO QA] Use postCodeReviewResults.sh from claude-review-toolkit#91614
Closed
kacper-mikolajczak wants to merge 1 commit into
Closed
[NO QA] Use postCodeReviewResults.sh from claude-review-toolkit#91614kacper-mikolajczak wants to merge 1 commit into
kacper-mikolajczak wants to merge 1 commit into
Conversation
Replaces the inline jq+while-loop in the 'Post code review results' step with a single postCodeReviewResults.sh call. Behaviour identical to today: 0 violations leaves a +1 reaction, otherwise N inline comments are posted via createInlineComment.sh. Bumps the claude-review-toolkit pin to the SHA that introduces the new script.
Contributor
Author
|
Superseded by #91689 (consolidated slice 2 work into one PR per repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Adopts the new
postCodeReviewResults.shhelper added in Expensify/GitHub-Actions#66. Replaces the inlinejq+ while-loop in thePost code review resultsstep with a single script call. Bumps theclaude-review-toolkitpin to the SHA that introduces the script.No steady-state behaviour change: 0 violations ->
+1reaction; N violations -> N inline comments viacreateInlineComment.sh(failures per comment swallowed with|| true); emptySTRUCTURED_OUTPUT->::error::+ exit 1.This is part of slice 2 of the centralisation effort. The toolkit pin currently points at the SHA on the toolkit PR branch and will be re-stamped to the merged-
mainSHA once Expensify/GitHub-Actions#66 lands.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/635397
PROPOSAL:
Tests
N/A - CI infrastructure with no user-facing behaviour change. Validation happens via the workflow itself running on this PR (will only fully validate once the toolkit SHA is re-stamped post-merge of Expensify/GitHub-Actions#66).
Offline tests
N/A - CI infrastructure change; doesn't affect runtime offline behaviour.
QA Steps
@Julesssss and @kacper-mikolajczak will check out some AI Reviewer workflow runs on real PRs after merge.
PR Author Checklist
Screenshots/Videos
Android: Native
N/A - CI infraAndroid: mWeb Chrome
N/A - CI infraiOS: Native
N/A - CI infraiOS: mWeb Safari
N/A - CI infraMacOS: Chrome / Safari
N/A - CI infracc @Julesssss