Skip to content

[HOLD] Update SQLite to branch hctree-bedrock-lcd-ex#2620

Open
flodnv wants to merge 2 commits into
mainfrom
flo_updateSQLite2
Open

[HOLD] Update SQLite to branch hctree-bedrock-lcd-ex#2620
flodnv wants to merge 2 commits into
mainfrom
flo_updateSQLite2

Conversation

@flodnv
Copy link
Copy Markdown
Contributor

@flodnv flodnv commented May 28, 2026

Details

Fixed Issues

Redo of #2605 with a bug fix:

contains a fix to a problem that could cause certain kinds of UPDATE (and maybe other) statements to erroneously record full table scans. It also emits a log message each time a BEGIN CONCURRENT transaction records a full-table scan of an IPK table. Hopefully that won't be too many log messages..

Needs #2619 which was broken out in another PR.

Tests


Internal Testing Reminder: when changing bedrock, please compile auth against your new changes

@flodnv flodnv self-assigned this May 28, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c74be1d1f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread libstuff/sqlite3.c
}

/* If everything still looks ok, proceed with the commit. */
if( rc==SQLITE_OK ){
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop replaying writes after an error

During a BEGIN CONCURRENT logical commit, this block replays every recorded write but the inner loop keeps running after btreeCursorOpen(), btreeMoveto(), or sqlite3BtreeInsert() returns an error, and the delete path drops the sqlite3BtreeDelete() return value entirely. If any replayed write hits an IO/OOM/corruption error while a later write succeeds, rc can be overwritten back to SQLITE_OK and the commit can complete after applying only part of the transaction's write set.

Useful? React with 👍 / 👎.

@flodnv flodnv changed the title Update SQLite to branch hctree-bedrock-lcd-ex [HOLD] Update SQLite to branch hctree-bedrock-lcd-ex May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants