Add postCodeReviewResults.sh to claude-review-toolkit#68
Merged
Conversation
This was referenced May 26, 2026
kacper-mikolajczak
force-pushed
the
slice2
branch
2 times, most recently
from
d113e05 to
eeee643
Compare
kacper-mikolajczak
changed the title
Contributor
Author
|
cc @Julesssss @rlinoz for review 🙏 This is the base of the set - it adds |
Julesssss
reviewed
Jun 1, 2026
Julesssss
reviewed
Jun 1, 2026
Contributor
Julesssss
left a comment
Julesssss
left a comment
There was a problem hiding this comment.
Looking good other than that.
Hoist the post-review-results loop (count violations -> +1 reaction when clean, else one inline comment per violation) out of each client claude-review.yml and into a shared toolkit script on PATH. Reads STRUCTURED_OUTPUT from env.
kacper-mikolajczak
force-pushed
the
slice2
branch
from
eeee643 to
416438a
Compare
Julesssss
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The "post review results" step - count violations, add a
+1reaction when the review is clean, otherwise post one inline comment per violation - is currently copy-pasted verbatim into theclaude-review.ymlof every client repo (App, Auth, Web-Expensify). It is pure boilerplate and the only meaningful logic in those workflows that the sharedclaude-review-toolkitdoes not yet own.What
postCodeReviewResults.shto theclaude-review-toolkitcomposite action'sscripts/directory (already placed onPATHby the action). It reads the review JSON from$STRUCTURED_OUTPUTand reuses the toolkit's existingaddPrReaction.sh/createInlineComment.sh. Individual comment failures are swallowed so one rejected comment does not kill the loop.README.mdscripts table.Usage:
postCodeReviewResults.sh <PR_NUMBER>withSTRUCTURED_OUTPUT,GH_TOKEN,GITHUB_REPOSITORY, andALLOWED_RULES_FILEin env.Scope
Intentionally limited to the
postCodeReviewResults.shhoist only - no other changes.Client adoption